This repository was archived by the owner on Apr 13, 2020. It is now read-only.
[FEATURE] Specific error code for deployment onboard command #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiyaakhtar
reviewed
Apr 7, 2020
| } catch (err) { | ||
| // TOFIX: write some comments on why this error can be ignore | ||
| logger.error( | ||
| `Unable to set storage account and table names in configuration file. \n ${err}` |
Collaborator
There was a problem hiding this comment.
Is there a reason this error can be ignored?
Collaborator
Author
There was a problem hiding this comment.
i just added a TOFIX on why this error can be ignored. It is ignored. I do not change anything. Can you elaborate on your question? thanks
samiyaakhtar
approved these changes
Apr 7, 2020
andrebriggs
approved these changes
Apr 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes microsoft/bedrock#1321