This repository was archived by the owner on Apr 13, 2020. It is now read-only.
[INFRA] Support for local paths Nate.infra.relative paths #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisseah
reviewed
Apr 9, 2020
dennisseah
reviewed
Apr 9, 2020
NathanielRose
changed the title
NathanielRose
requested review from
andrebriggs,
bnookala,
edaena,
evanlouie,
jmspring,
mtarng,
samiyaakhtar,
sarath-p and
yradsmikham
dennisseah
approved these changes
Apr 10, 2020
yradsmikham
suggested changes
Apr 10, 2020
| describe("test checkModuleSource function", () => { | ||
| it("positive test", () => { | ||
| let res = checkModuleSource(`source="../../azure/aks-gitops"`); | ||
| expect(res).toBeTruthy(); |
There was a problem hiding this comment.
Let's change this to expect(res).toBe(true) instead. This article is good at explaining why: https://vincenttunru.com/toBeTruthy-vs-toBe-true/
Same for the one below.
There was a problem hiding this comment.
checkModuleSource is returning boolean. using is toBeTruthy is ok.
|
Also, did we need to update the smoke tests? |
This is in a separate PR |
andrebriggs
approved these changes
Apr 10, 2020
yradsmikham
approved these changes
Apr 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.