Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring time schedule interval #1168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow configuring time schedule interval #1168

wants to merge 2 commits into from

Conversation

ImranR98
Copy link

Resolves #960

@Catfriend1
Copy link
Owner

Thank you 😊. Cool, that came unexpected but I welcome your work on this 👍. I'll have a look during one of the next dev sessions.

@Catfriend1 Catfriend1 self-requested a review October 28, 2024 22:03
@Catfriend1
Copy link
Owner

@ImranR98 Do you have a test APK at hand I could try this out easily?

@ImranR98
Copy link
Author

@ImranR98 Do you have a test APK at hand I could try this out easily?

Sure. GitHub isn't letting me upload files >25MB.
I've uploaded it here: https://send.vis.ee/download/5c6cd809b1e2b4c5/#31Tgflnf5pRk9D4MkmabQQ
Let me know if I should use some other method.

@ImranR98
Copy link
Author

ImranR98 commented Nov 1, 2024

Hey, just checking in - is there anything else needed for this PR?

@Catfriend1
Copy link
Owner

All fine, I just need to take time to do a next dev session. :)

@Catfriend1
Copy link
Owner

Not sure I make it before christmas... but it's still on my todo list to give this a release as well. 1.28.1 is also coming in :)... . Or we'll do community testing if 1.28.0 is not urgently broken and see what the feedback is. This would save my time a lot to label this as included in a 1.28.1-preview .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Catfriend1 Catfriend1 Catfriend1 left review comments

Assignees

@ImranR98 ImranR98

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configuring time schedule interval
2 participants
@ImranR98 @Catfriend1