Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump npm from 7.6.0 to 7.6.3 #1400

Merged
merged 2 commits into from
Mar 20, 2021
Merged

Bump npm from 7.6.0 to 7.6.3 #1400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b15e768
Bump npm from 7.6.0 to 7.6.3
dependabot[bot] Mar 19, 2021
33c61bc
hotfix sidebar test
dmetzner Mar 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"js-yaml": "^4.0.0",
"lazysizes": "^5.3.0",
"material-design-icons": "^3.0.1",
"npm": "^7.6.0",
"npm": "^7.6.3",
"popper.js": "^1.16.1",
"sweetalert2": "^10.15.6",
"textfilljs": "^1.0.3-a",
Expand Down
7 changes: 7 additions & 0 deletions tests/behat/features/web/general/sidebar.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,33 @@ Feature: Sidebar Navigation

Scenario: Button opens and closes sidebar
Given I am on the homepage
And I wait for the page to be loaded
Then the element "#sidebar" should not be visible
And the element "#sidebar-overlay" should not be visible
When I click "#top-app-bar__btn-sidebar-toggle"
And I wait for the page to be loaded
Then the url should match "/app/$"
And the element "#sidebar" should be visible
And the element "#sidebar-overlay" should be visible
When I click "#top-app-bar__btn-sidebar-toggle"
And I wait for the page to be loaded
Then the url should match "/app/$"
And the element "#sidebar" should not be visible
And the element "#sidebar-overlay" should not be visible

Scenario: Back button closes sidebar
Given I am on the homepage
And I wait for the page to be loaded
And I open the menu
And I click "#btn-login"
And I wait for the page to be loaded
And I click "#top-app-bar__btn-sidebar-toggle"
And I wait for the page to be loaded
Then the url should match "/app/login$"
And the element "#sidebar" should be visible
And the element "#sidebar-overlay" should be visible
When I click browser's back button
And I wait for the page to be loaded
Then the url should match "/app/login"
And the element "#sidebar" should not be visible
And the element "#sidebar-overlay" should not be visible