Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker config #5309

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

schaubes
Copy link
Collaborator

For easier development and deployment


Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing (CI), if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Ask for a code reviewer
  • Check that your pull request has been successfully deployed to https://web-test-1.catrob.at/

Additional Description

None

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.36%. Comparing base (233cf95) to head (e6163ad).
Report is 239 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5309      +/-   ##
=============================================
+ Coverage      46.79%   49.36%   +2.57%     
- Complexity      6126     6210      +84     
=============================================
  Files            681      695      +14     
  Lines          21426    22032     +606     
=============================================
+ Hits           10026    10876     +850     
+ Misses         11400    11156     -244     
Flag Coverage Δ
behat 47.17% <ø> (+2.13%) ⬆️
phpunit 8.38% <ø> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmetzner dmetzner merged commit 3845c59 into Catrobat:develop Oct 22, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants