Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCC-298 Check if #TODOs in converter.py are still relevant [TN] #241

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

STCC-298 Check if #TODOs in converter.py are still relevant [TN] #241

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1551c43
Merge remote-tracking branch 'Catrobat/develop' into develop
TauBossss Jul 27, 2021
c0ae2ce
Merge remote-tracking branch 'Catrobat/develop' into develop
TauBossss Oct 5, 2021
6726024
STCC-298 Check if #TODOs in converter.py are still relevant [TN]
TauBossss Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/scratchtocatrobat/converter/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ def create_script(cls, scratch_script_name, arguments, catrobat_project, sprite,
if scratch_script_name not in scratch.SCRIPTS:
assert False, "Missing script mapping for: " + scratch_script_name
catrobat_script = cls.catrobat_script_class_for(scratch_script_name)
# TODO: register handler!! -> _ScriptBlocksConversionTraverser

if scratch_script_name == scratch.SCRIPT_SENSOR_GREATER_THAN:
formula = _create_modified_formula_brick(arguments[0], arguments[1], catrobat_project, sprite)
when_cond_brick = catbricks.WhenConditionBrick()
Expand Down Expand Up @@ -1832,7 +1832,6 @@ class _ScratchObjectConverter(object):
_scratch_project = None

def __init__(self, catrobat_project, scratch_project, progress_bar=None, context=None):
# TODO: refactor static
_ScratchObjectConverter._catrobat_project = catrobat_project
_ScratchObjectConverter._scratch_project = scratch_project
self._progress_bar = progress_bar
Expand Down