-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/10 보여주는 결과의 확장 필요성 #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "10-\uBCF4\uC5EC\uC8FC\uB294-\uACB0\uACFC\uC758-\uD655\uC7A5-\uD544\uC694\uC131"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Output을 선택적으로 가져올수 있는 부분 너무 좋습니다!
❗코드에서 에러가 나서 다음과 같이 고치긴했는데 제 환경문제인가 싶어서요오! 한번 더 확인해주세요!
streamlit_app.py
from connect_db import ConnectDB
-> from llm_utils.connect_db import ConnectDB
st.write("결과:", res["generated_query"].content)
-> st.write("결과:", res["generated_query"])
sql = res["generated_query"].content.split("```")[1][
3:
] # 쿼리 앞쪽의 "sql " 제거
-> sql = res["generated_query"] # 쿼리 앞쪽의 "sql " 제거
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 좋은 기능인 것 같아요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 좋은 것 같습니다! 혹시 코드가 조금 길어지는 것 같으시면, 일부 코드를 모듈화 할 수도 있을 것 같습니다! sidebar의 경우 with 구문으로 사용하시는 방법도 고려해보시면 좋을 것 같아요
👍너무 좋습니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 좋습니다
Feature/evaluation viz
…ceLab/Lang2SQL into 10-보여주는-결과의-확장-필요성
👍 #64 에서 한번에 머지되도록 하겠습니다. @anjaaaaeeeellll님 감사합니다!! |
#️⃣ Issue Number
📝 요약(Summary)
💬 To Reviewers (선택)
PR Checklist
reference) How to Code Review