Skip to content

docs: add pull_request_guidelines.md #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

docs: add pull_request_guidelines.md #84

merged 1 commit into from
May 2, 2025

Conversation

ParkGyeongTae
Copy link
Contributor

#️⃣ Issue Number

📝 요약(Summary)

  • PR 관련 가이드라인

💬 To Reviewers (선택)

  • 없음

PR Checklist

  • 없음

reference) How to Code Review

  • 따봉(👍): 리뷰어가 리뷰이의 코드에서 칭찬의 의견을 남기고 싶을 때 사용합니다.
  • 느낌표(❗): 리뷰어가 리뷰이에게 필수적으로 코드 수정을 요청할 때 사용합니다.
  • 물음표 (❓): 리뷰어가 리뷰이에게 의견을 물어보고 싶을 때 사용합니다.
  • 알약 (💊): 리뷰어가 리뷰이의 코드에서 개선된 방법을 제안하지만 그것의 반영이 필수까지는 아닐 때 사용합니다.

@ParkGyeongTae ParkGyeongTae self-assigned this Apr 30, 2025
ehddnr301
ehddnr301 approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@ehddnr301 ehddnr301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 감사합니다!! 내용이 잘 정리된것으로 보입니다!

@ParkGyeongTae
Copy link
Contributor Author

👍 감사합니다!! 내용이 잘 정리된것으로 보입니다!

@ehddnr301 확인했습니다~ 감사합니다!

anjaaaaeeeellll
anjaaaaeeeellll approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@anjaaaaeeeellll anjaaaaeeeellll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 좋습니다!

@ParkGyeongTae
Copy link
Contributor Author

@anjaaaaeeeellll 확인 감사합니다~~

@ParkGyeongTae ParkGyeongTae merged commit 47d3fde into master May 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehddnr301 ehddnr301 ehddnr301 approved these changes

@anjaaaaeeeellll anjaaaaeeeellll anjaaaaeeeellll approved these changes

Assignees

@ParkGyeongTae ParkGyeongTae

Labels
None yet
Projects
None yet
Milestone
Mission: Version 1.0.0 Complete ✅
Development

Successfully merging this pull request may close these issues.
3 participants
@ParkGyeongTae @ehddnr301 @anjaaaaeeeellll