Skip to content

fix: update requirements.txt and .gitignore #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

ParkGyeongTae
Copy link
Contributor

#️⃣ Issue Number

📝 요약(Summary)

  • 호환성을 위한 Numpy 버전관리 및 .gitignore 수정

💬 To Reviewers (선택)

  • 없음

PR Checklist

  • 없음

reference) How to Code Review

  • 따봉(👍): 리뷰어가 리뷰이의 코드에서 칭찬의 의견을 남기고 싶을 때 사용합니다.
  • 느낌표(❗): 리뷰어가 리뷰이에게 필수적으로 코드 수정을 요청할 때 사용합니다.
  • 물음표 (❓): 리뷰어가 리뷰이에게 의견을 물어보고 싶을 때 사용합니다.
  • 알약 (💊): 리뷰어가 리뷰이의 코드에서 개선된 방법을 제안하지만 그것의 반영이 필수까지는 아닐 때 사용합니다.

Copy link
Collaborator

@ehddnr301 ehddnr301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 감사합니다! .gitignore 관련해서 reranking을 사용하게 된다면 경로에 ko_reranker_local 도 함께 생성이 되는데 괜찮으시다면 ko_reranker_local 도 함께 gitignore에 추가하도록 하겠습니다. 체크 이모지 눌러주시면 제가 추가하겠습니다! @ParkGyeongTae

❓ numpy 버전관련해서 에러가 발생하는군요! 최초발견하게된 계기나 오류도 공유가능하시다면 남겨주시면 좋을것 같습니다아! (현재 기록이 남아있지않다면 괜찮습니다ㅎㅎ)

@ParkGyeongTae
Copy link
Contributor Author

👍 감사합니다! .gitignore 관련해서 reranking을 사용하게 된다면 경로에 ko_reranker_local 도 함께 생성이 되는데 괜찮으시다면 ko_reranker_local 도 함께 gitignore에 추가하도록 하겠습니다. 체크 이모지 눌러주시면 제가 추가하겠습니다! @ParkGyeongTae

❓ numpy 버전관련해서 에러가 발생하는군요! 최초발견하게된 계기나 오류도 공유가능하시다면 남겨주시면 좋을것 같습니다아! (현재 기록이 남아있지않다면 괜찮습니다ㅎㅎ)

@ehddnr301 오호.. 추가해야할 무시파일 추가 부탁드립니다~! 에러는 재현해서 이력을 코멘트로 남겨보겠습니다~!~!

@ParkGyeongTae
Copy link
Contributor Author

ParkGyeongTae commented May 1, 2025

@ehddnr301

재현 방법은 다음과 같습니다.

# 가상환경 생성
conda create -n lang2sql2 python=3.12 -y

# 가상환경 활성화
conda activate lang2sql2

# 라이브러리 설치
pip install -r requirements.txt

에러로그

(lang2sql2) ➜  Lang2SQL git:(feature/85-fix-numpy-version) ✗ lang2sql --datahub_server http://34.125.222.80:8080 run-streamlit

  You can now view your Streamlit app in your browser.

  Local URL: http://localhost:8501
  Network URL: http://192.168.45.195:8501

  For better performance, install the Watchdog module:

  $ xcode-select --install
  $ pip install watchdog
            

A module that was compiled using NumPy 1.x cannot be run in
NumPy 2.2.5 as it may crash. To support both 1.x and 2.x
versions of NumPy, modules must be compiled with NumPy 2.0.
Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

If you are a user of the module, the easiest solution will be to
downgrade to 'numpy<2' or try to upgrade the affected module.
We expect that some modules will need time to support NumPy 2.

Traceback (most recent call last):  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/threading.py", line 1032, in _bootstrap
    self._bootstrap_inner()
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/threading.py", line 1075, in _bootstrap_inner
    self.run()
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/threading.py", line 1012, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 320, in _run_script_thread
    self._run_script(request.rerun_data)
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 595, in _run_script
    ) = exec_func_with_error_handling(code_to_exec, ctx)
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/streamlit/runtime/scriptrunner/exec_code.py", line 88, in exec_func_with_error_handling
    result = func()
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 579, in code_to_exec
    exec(code, module.__dict__)
  File "/Users/pgt0409/Desktop/git/Lang2SQL/interface/streamlit_app.py", line 75, in <module>
    st.navigation(pages).run()
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/streamlit/navigation/page.py", line 303, in run
    exec(code, module.__dict__)
  File "/Users/pgt0409/Desktop/git/Lang2SQL/interface/lang2sql.py", line 13, in <module>
    from llm_utils.graph import builder
  File "/Users/pgt0409/Desktop/git/Lang2SQL/llm_utils/graph.py", line 17, in <module>
    from llm_utils.retrieval import search_tables
  File "/Users/pgt0409/Desktop/git/Lang2SQL/llm_utils/retrieval.py", line 7, in <module>
    from transformers import AutoModelForSequenceClassification, AutoTokenizer
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/transformers/__init__.py", line 26, in <module>
    from . import dependency_versions_check
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/transformers/dependency_versions_check.py", line 16, in <module>
    from .utils.versions import require_version, require_version_core
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/transformers/utils/__init__.py", line 25, in <module>
    from .chat_template_utils import DocstringParsingException, TypeHintParsingException, get_json_schema
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/transformers/utils/chat_template_utils.py", line 40, in <module>
    from torch import Tensor
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/torch/__init__.py", line 1477, in <module>
    from .functional import *  # noqa: F403
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/torch/functional.py", line 9, in <module>
    import torch.nn.functional as F
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/torch/nn/__init__.py", line 1, in <module>
    from .modules import *  # noqa: F403
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/torch/nn/modules/__init__.py", line 35, in <module>
    from .transformer import TransformerEncoder, TransformerDecoder, \
  File "/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/torch/nn/modules/transformer.py", line 20, in <module>
    device: torch.device = torch.device(torch._C._get_default_device()),  # torch.device('cpu'),
/Users/pgt0409/opt/anaconda3/envs/lang2sql2/lib/python3.12/site-packages/torch/nn/modules/transformer.py:20: UserWarning: Failed to initialize NumPy: _ARRAY_API not found (Triggered internally at /Users/runner/work/pytorch/pytorch/pytorch/torch/csrc/utils/tensor_numpy.cpp:84.)
  device: torch.device = torch.device(torch._C._get_default_device()),  # torch.device('cpu'),

@ehddnr301
Copy link
Collaborator

@ParkGyeongTae .gitignore에 ko_reranker_local 도 추가했습니다!

👍 ML관련 모듈들이 유난히 의존성관리가 어려웠던 기억이 있네요ㅜㅜ! 체크해주셔서 감사합니다!

@ParkGyeongTae
Copy link
Contributor Author

@ehddnr301 확인했습니다~! 한분이 더 리뷰해주시면 머지하겠습니다~

Copy link
Contributor

@seyoung4503 seyoung4503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 아주 좋습니다

@ParkGyeongTae
Copy link
Contributor Author

@seyoung4503 확인 감사합니다~~~!

@ParkGyeongTae ParkGyeongTae merged commit 585c032 into master May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants