Skip to content

CLI 로깅 추가 및 Datahub GMS 연결체크 기능 분리 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ParkGyeongTae
Copy link
Contributor

#️⃣ Issue Number

📝 요약(Summary)

  • CLI 로깅 추가 및 Datahub GMS 연결체크 기능 분리
  • lang2sql 실행시 실행과정을 로깅으로 나타내 동작을 확인할 수 있도록 수정
  • DataHub GMS 서버 연결부분을 메인 로직에서 분리하여, 단일 기능만 수행하도록 수정

image

💬 To Reviewers (선택)

  • 없음

PR Checklist

  • lang2sql --datahub_server http://34.125.222.80:8080 run-streamlit

reference) How to Code Review

  • 따봉(👍): 리뷰어가 리뷰이의 코드에서 칭찬의 의견을 남기고 싶을 때 사용합니다.
  • 느낌표(❗): 리뷰어가 리뷰이에게 필수적으로 코드 수정을 요청할 때 사용합니다.
  • 물음표 (❓): 리뷰어가 리뷰이에게 의견을 물어보고 싶을 때 사용합니다.
  • 알약 (💊): 리뷰어가 리뷰이의 코드에서 개선된 방법을 제안하지만 그것의 반영이 필수까지는 아닐 때 사용합니다.

Copy link
Collaborator

@ehddnr301 ehddnr301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 logging 및 health check 작동하는것 확인하였습니다!

성공시

2025-05-14 13:04:37 [INFO] Initialization started: GMS server = http://localhost:8080, run_streamlit = False, port = 8501
2025-05-14 13:04:37 [INFO] GMS server is healthy: http://localhost:8080
2025-05-14 13:04:37 [INFO] GMS server URL successfully set: http://localhost:8080
2025-05-14 13:04:37 [INFO] Executing 'run-streamlit' command on port 8501...
2025-05-14 13:04:37 [INFO] Starting Streamlit application on port 8501...

실패시

2025-05-14 13:04:47 [INFO] Initialization started: GMS server = http://localhost:8081, run_streamlit = False, port = 8501
2025-05-14 13:04:48 [ERROR] GMS server returned HTTP error: http://localhost:8081/health | 404 Client Error: Not Found for url: http://localhost:8081/health
2025-05-14 13:04:48 [ERROR] GMS server health check failed. URL: http://localhost:8081

@ParkGyeongTae
Copy link
Contributor Author

@ehddnr301 확인 감사합니다~!

@ParkGyeongTae ParkGyeongTae merged commit e6e457f into master May 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants