Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Projected Profiles For Scrap Types #186

Open
vpicaver opened this issue Sep 30, 2020 · 11 comments
Open

Support Projected Profiles For Scrap Types #186

vpicaver opened this issue Sep 30, 2020 · 11 comments
Assignees
Milestone

Comments

@vpicaver
Copy link
Contributor

It would be nice to support Projected Profiles. This would enable cross-sections and other Projected Profiles in CaveWhere. This is the same warping algorithm as plan, but the view is different.

@vpicaver vpicaver added this to the 1.0 milestone Sep 30, 2020
@vpicaver vpicaver self-assigned this Sep 30, 2020
@vpicaver vpicaver changed the title Support Projected Profiles Support Projected Profiles For Scrap Types Sep 30, 2020
@echarlie
Copy link
Contributor

echarlie commented Nov 3, 2020

I've put some testing on the (partial?) implementation of this in 26b1b98 through 19db0c4. Thus far it seems to work well. however, 1) the UI is less-than-intuitive (I don't know how to fix that other than documentation; I figured it out eventually), and 2) it would be nice if it guessed projection plane based on shots.

@vpicaver
Copy link
Contributor Author

vpicaver commented Nov 4, 2020

I'm currently working on a blog post and video now. The biggest issue is the the user currently has to select a valid azimuth for the profile. Do you remember what you tried first, because that's usually most intuitive approach. It's a good idea, if CaveWhere could automatically guess the profile plane's azimuth.

@echarlie
Copy link
Contributor

I thought L->R or R->L would end up being the most sane, but quickly figured out it was easiest to just manipulate the 3d viewer to set view az to what I recalled the cross-section as being, and then plugging that in to "looking at"; starting from the shot azimuth may work just as well. It's also a little harder to get reasonable results, since guessing up and scale doesn't work as predictably as in profile or plan; it was mostly a matter of trial and error.

@vpicaver
Copy link
Contributor Author

vpicaver commented Dec 2, 2020

So I've been playing around with this tonight. I think the azimuth can also be auto calculated if using sketched-to-scale sketch. Below is an example projected profile:
Profile

I've iterated through all the azimuths and graphed the error generate by each azimuth. There's two error components for the note transform:

  1. Scale error
  2. Direction error

Error

These errors can be normalized and summed. From some brief experimentation with real cave data, I've found that Minimizing the Direction error tends to give the best results. The algorithm only works for good sketches. Poorly sketched sketches, can produce bad results.

@vpicaver
Copy link
Contributor Author

vpicaver commented Dec 2, 2020

I basically need to write an algorithm that quickly iterates through azimuths and choose the best azimuth by minimizing the error. The example above, the correct answer is azimuth 135 degrees.

@vpicaver
Copy link
Contributor Author

vpicaver commented Dec 2, 2020

I think the only case, where this algorithm would fail, is if projected profile is UP or DOWN shot. Then the projection plan could be any azimuth.

@vpicaver
Copy link
Contributor Author

vpicaver commented Dec 5, 2020

@echarlie CaveWhere now automatically find the correct azimuth for the Project Profile Projection in 9fa93a0

@echarlie
Copy link
Contributor

echarlie commented Dec 8, 2020

I gave it a quick spin with some data I had with 2-4 stations in the cross section: usually it ended up off by 40° (for all "orientations" of l-r, r-l, and "looking at"). This may be a consequence of the sketches not being accurately to scale; I'll give it a go with some constructed data.

@vpicaver
Copy link
Contributor Author

vpicaver commented Dec 9, 2020 via email

@echarlie
Copy link
Contributor

c.f. Bristol's comment about "prolific sketchers who don't use protractors"... This was mostly for near-horizontal shots and stations practically in-plane with each other: what should be almost perfect conditions. So I was surprised.

@vpicaver
Copy link
Contributor Author

Do you think it's better than not trying to find it the azimuth automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants