fix: Enable multi-sector search for cross-sector memory retrieval #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HSG algorithm had a fundamental flaw where it only searched within sectors that matched the query's classification. This caused memories stored in one sector (e.g., reflective) to be invisible to queries classified as another sector (e.g., episodic). Changes: - Search ALL sectors by default instead of only classified sectors - Add sector relationship matrix with graduated penalties (0.3-0.8) - Add tag matching to scoring formula (0.10 weight) - Adjust scoring weights: similarity 0.6→0.4, recency 0.05→0.15 - Add temporal marker detection for date-based queries - Add compute_tag_match_score function for tag-based boosting - Apply sector relationship penalty for cross-sector results Before: Query "what did I do today 2025-11-20" couldn't find reflective memories from today because it was classified as episodic and only searched episodic sector. After: Same query finds reflective memories and returns them with appropriate sector penalty applied, enabling true cross-sector retrieval. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
Hey amihos, thanks for your interest in OpenMemory. I appreciate your pull request but it has failed the Build Test, please resolve the issues. |
Fixed TypeScript build errors by properly adding AWS_REGION, AWS_ACCESS_KEY_ID, and AWS_SECRET_ACCESS_KEY properties to the env configuration object. These properties were being referenced in embed.ts but were missing from cfg.ts. Changes: - Removed incorrect aws_model property with 3-argument str() call - Added AWS_REGION, AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY as individual properties with proper default values Fixes TypeScript errors: - cfg.ts(53,9): Expected 2 arguments, but got 3 - embed.ts: Property 'AWS_*' does not exist errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The HSG algorithm only searched within sectors matching the query's classification. A query "what did I do today" (classified as episodic) couldn't find memories stored in the reflective sector, even if they contained relevant information from today.
Solution
Test Results
Test Plan
🤖 Generated with Claude Code