more fixes

CedarEDA · Nov 19, 2024 · 894e0dc · 894e0dc
1 parent a353bb1
commit 894e0dc
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 23 deletions.
diff --git a/Manifest.toml b/Manifest.toml
diff --git a/test/ddt.jl b/test/ddt.jl
@@ -29,7 +29,8 @@ let sys = IRODESystem(ddt_nonlinear; debug_config=(; store_ss_levels=true))
 
     for sol in solve_dae(sys, [0.], [1.], (0., 1.); reltol=1e-6)
         @test all(isapprox.(sol[sys.x], exp.(sol.t), atol=1e-4))
-        @test all(isapprox.(sol[sys.y], exp.(sol.t), atol=1e-4))
+        #DAECompiler incorrectly tries to interpolate based on algebraic vars
+        @test_broken all(isapprox.(sol[sys.y], exp.(sol.t), atol=1e-4))
     end
 
     for level in dbg.ss_levels
@@ -50,8 +51,11 @@ end
 let sys = IRODESystem(ddt_nonlinear2; debug_config=(; store_ss_levels=true))
     dbg = getfield(sys, :debug_config)
 
-    for sol in (solve_dae(sys, [0., 0.], [1., 1.], (0., 1.))...,
-                solve_ode(sys, [1., 1., 0., 0.], (0., 1.))..., )
+    for sol in solve_dae(sys, [0., 0.], [1., 1.], (0., 1.))
+        @test all(isapprox.(sol[sys.x], exp.(sol.t), atol=1e-2))
+        @test all(isapprox.(sol[sys.y], exp.(sol.t), atol=1e-2))
+    end
+    for sol in solve_ode(sys, [1., 1., 0., 0.], (0., 1.))
         @test all(isapprox.(sol[sys.x], exp.(sol.t), atol=1e-2))
         @test all(isapprox.(sol[sys.y], exp.(sol.t), atol=1e-2))
     end

diff --git a/test/implied_alias.jl b/test/implied_alias.jl
@@ -4,7 +4,6 @@ using Test
 using SciMLBase
 using DAECompiler
 using DAECompiler.Intrinsics
-using OrdinaryDiffEq
 
 include("testutils.jl")
 

diff --git a/test/regression.jl b/test/regression.jl
@@ -371,6 +371,7 @@ function (p::OneParam)()
     equation!(state_ddt(state_ddt(y)) - z*ẍ)
     equation!(x - ẍ)
 end
+using Sundails
 let sys = IRODESystem(Tuple{OneParam}; debug_config=(;store_ir_levels=true, store_ss_levels=true));
     daeprob = DAEProblem(sys, [0., 0., 0.], [1., 0., 1.], (0., 1.), OneParam(1.));
     sol = solve(daeprob, IDA())