Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #411 #412

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Fix #411 #412

merged 3 commits into from
Sep 13, 2023

Conversation

qchempku2017
Copy link
Collaborator

@qchempku2017 qchempku2017 commented Sep 12, 2023 •
edited by lbluque
Loading

Summary

Additional dependencies introduced (if any)

TODO (if any)

Checklist

@qchempku2017 qchempku2017 mentioned this pull request Sep 12, 2023
Closed
@lbluque
Copy link
Collaborator

lbluque commented Sep 13, 2023

Thanks a lot @qchempku2017 !

@lbluque lbluque merged commit 3b538fc into CederGroupHub:main Sep 13, 2023
@lbluque lbluque mentioned this pull request Sep 15, 2023
Closed
@lbluque lbluque added the fix label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbluque lbluque lbluque approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate properties dictionary for Vacancy class
2 participants
@qchempku2017 @lbluque