Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Mouse focus when cursor leaves window #423

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Fix: Mouse focus when cursor leaves window #423

merged 4 commits into from
Jul 19, 2024

Conversation

EdnY1
Copy link
Contributor

@EdnY1 EdnY1 commented Jul 15, 2024

This PR addresses the following issue:

  • Before:
before_fix.mp4
  • After:
after_fix.mp4
  • The html used to reproduce the issue:
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>QCefView Mouse Focus Issue</title>
  </head>
  <style>
    body {
        margin: 0;
        height: 100vh;
        display: flex;
    }
    .left {
        width: 50vw;
        height: 100%;
        background: blue;
    }
    .right {
        width: 50vw;
        height: 100%;
        background: red;

        &:hover {
            opacity: .5;
        }
    }
  </style>
  <body>
    <div class="left"></div>
    <div class="right"></div>
  </body>
</html>

tishion
tishion reviewed Jul 16, 2024
View reviewed changes
include/QCefView.h Outdated Show resolved Hide resolved
tishion
tishion reviewed Jul 16, 2024
View reviewed changes
src/QCefView.cpp Outdated Show resolved Hide resolved
tishion
tishion reviewed Jul 16, 2024
View reviewed changes
src/QCefView.cpp Outdated Show resolved Hide resolved
tishion
tishion reviewed Jul 18, 2024
View reviewed changes
src/QCefView.cpp Outdated Show resolved Hide resolved
@tishion
Copy link
Member

tishion commented Jul 18, 2024

hi @EdnY1, thank you so much for your contribution. there is only 1 comment to resolve now.

Once you addressed it and we can merge this PR immediately.

@tishion
Copy link
Member

tishion commented Jul 19, 2024

Thank you @EdnY1

tishion
tishion approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@tishion tishion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTM

@tishion tishion merged commit a13f04e into CefView:main Jul 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tishion tishion tishion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdnY1 @tishion