Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default params in BitmapGRF methods #35

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

Cellivar
Copy link
Owner

I'm going to bed.

@Cellivar Cellivar marked this pull request as ready for review December 29, 2022 13:28
@Cellivar Cellivar enabled auto-merge (squash) December 29, 2022 13:28
@github-actions
Copy link

Code coverage

Filename Statements Branches Functions Lines
src/Documents/BitmapGRF.ts 52.55% 51.35% 66.67% 53.78%
src/WebZlpError.ts 33.33% 100% 50% 33.33%
src/index.ts 100% 100% 100% 100%
src/Documents/Commands.ts 28.41% 43.33% 11% 11.35%
src/Printers/Configuration/PrinterOptions.ts 26.32% 66.67% 6.67% 12.5%
src/Printers/Models/PrinterModel.ts 38.1% 18.18% 11.11% 13.33%
src/Printers/Configuration/SerialPortSettings.ts 97.06% 100% 85.71% 85.71%
src/Printers/Configuration/MediaOptions.ts 69.23% 33.33% 62.5% 20%
src/Documents/ConfigDocument.ts 34.38% 0% 35.29% 34.38%
src/Documents/Document.ts 40.91% 0% 33.33% 45%
src/Documents/LabelDocument.ts 52% 69.23% 29.41% 45.45%
src/Documents/ReadyToPrintDocuments.ts 27.27% 100% 0% 22.22%
src/Printers/Communication/LineBreakTransformer.ts 0% 100% 0% 0%
src/Printers/Communication/PrinterCommunication.ts 76.92% 50% 50% 50%
src/Printers/Communication/UsbPrinterDeviceChannel.ts 4.23% 0% 0% 4.23%
src/Printers/Languages/EplPrinterCommandSet.ts 13.73% 13.85% 12.5% 14.38%
src/Printers/Models/PrinterModelDb.ts 11.54% 0% 0% 11.54%
src/Printers/Models/EplPrinterModels.ts 15.38% 100% 0% 15.38%
src/Printers/Languages/PrinterCommandSet.ts 20.41% 6.25% 17.24% 19.35%
src/Printers/PrinterCommunicationOptions.ts 0% 100% 0% 0%
src/Printers/Printer.ts 10.48% 0% 0% 10.58%
src/Printers/Languages/ZplPrinterCommandSet.ts 3.62% 0% 0% 3.65%
src/PrinterUsbManager.ts 4.35% 0% 0% 4.55%

@Cellivar Cellivar merged commit a88a130 into main Dec 29, 2022
@Cellivar Cellivar deleted the bugfix/default-params-are-annoying branch December 29, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant