Re-introduce slide view for several functions

[SecUpwN]

@E3V3A just proposed re-introducing the slide view for these functions (in this order):

• Cell Information
• Database Viewer
• Neighboring Cells View

While re-adding the slide view for these items, the already existing buttons within the left-side panel shall be kept. Can you tackle this, @xLaMbChOpSx?

[tobykurien]

I see "Cell Information" and "Database Viewer" is already in the drawer, so I assume you just want the "Neighbouring Cells" view? I don't see code for this view though - is that not in the map already?

[E3V3A]

@tobykurien I don't know actually, the neighboring Cells View works on GT-I9100 models, and only show a list of cells + ciphering info, not on map yet. This function refers to the ServiceMode code that i mentioned in private chat. So perhaps @xLaMbChOpSx can answer this?

[SecUpwN]

@tobykurien, I guess this Issue did not describe well enough what @E3V3A actually want to be added again. He would like to have the three functions mentioned in the OP to be added again as a slide-view. Means, once you open AIMSICD, you see the Device Details and can swipe to the left to access the three menus mentioned. The stuff that's in the drawer already is fine in my eyes.

[tobykurien]

Aaah ok, so you want to combine DeviceView, Cell Info, and Database Viewer into one view with tabs across the top, and the ability to swipe between them, correct? "Cell Information" - is that the same as Device information, or is that the same as Neighbouring cells?

[SecUpwN]

Yep, that's the way @E3V3A wants it. "Cell Information" is the tab with Neighboring Cells.

[SecUpwN]

@E3V3A, I have just checked the new slide-view function as proposed by you, but it only shows two tabs: Cell Information (with Neighbouring Cells) and Database Viewer. Is everything you wanted implemented in WIP-Internal v0.1.24-alpha-build 12 (grab it in Testroom), or did toby miss anything?

[E3V3A]

@SecUpwN I don't see how neighboring cells can be in cell info... But neighboring cell info should be the last view and separate, at the moment, because it relies on multi-client-ril SM interface, which usually FC or fails on most phones. I can't test this because of #143.

[E3V3A]

@tobykurien Yes, I tested 01.24-Alpha-b12 on GT-I9100 and it works (apart what you fixed the other day). However, if we keep that order, then we need to make sure Neighboring-cells view doesn't FC on other phones, which is why I wanted it to be the last view. @SecUpwN You can't use Neighboring-cells view, because of your phone.

[SecUpwN]

@E3V3A, what do you mean with "because of your phone"? Doesn't the HTC One M7 support that, or do you want to say that I'm running an unsupported ROM?

[E3V3A]

@SecUpwN You already know what I'm talking about, but forgotten. I'm talking about this: #27 (comment) If that doesn't work, it means your phone is not yet supported (by AIMSICD) for showing neighboring cells. But if you can take that and make it work for your phone, then we're all go!

[SecUpwN]

@E3V3A, l since this Issue seems to be solved, I am closing it now. If the slide-view FCs on other phones, please open a new Issue for those. Neighboring Cells, works on my HTC One.

[E3V3A]

@SecUpwN I can't test this on my other phone (I9195) because of issue #143. Please give me a screenshot. I had no idea Neighboring cells view worked on your HTC! If it really does, that is very good, because then there's little reason, it shouldn't work n many others, with some code modifications.