chore(tests): tests fixed

Celtian · May 24, 2024 · 11988df · 11988df
1 parent 43ed089
commit 11988df
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 65 deletions.
diff --git a/angular.json b/angular.json
@@ -129,7 +129,6 @@
           "builder": "@angular-devkit/build-angular:karma",
           "options": {
             "main": "projects/demo/src/test.ts",
-            "polyfills": "projects/demo/src/polyfills.ts",
             "tsConfig": "projects/demo/tsconfig.spec.json",
             "karmaConfig": "projects/demo/karma.conf.js",
             "assets": [

diff --git a/projects/demo/src/app/app.component.spec.ts b/projects/demo/src/app/app.component.spec.ts
@@ -1,4 +1,5 @@
-import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
+import { provideExperimentalZonelessChangeDetection } from '@angular/core';
+import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { NgxAppVersionOptions, provideAppVersion } from 'projects/ngx-app-version/src/public-api';
 import { AppComponent } from './app.component';
 
@@ -10,23 +11,23 @@ describe('AppComponent', () => {
     version: '1.0.0'
   };
 
-  beforeEach(waitForAsync(() => {
+  beforeEach(() => {
     TestBed.configureTestingModule({
       imports: [AppComponent],
-      providers: [provideAppVersion(mockOptions)]
+      providers: [provideExperimentalZonelessChangeDetection(), provideAppVersion(mockOptions)]
     }).compileComponents();
 
     fixture = TestBed.createComponent(AppComponent);
     component = fixture.componentInstance;
-  }));
+  });
 
   it('should create the app', () => {
     expect(component).toBeTruthy();
   });
 
-  it(`should get github link`, waitForAsync(() => {
+  it(`should get github link`, () => {
     fixture.detectChanges();
     const compiled = fixture.debugElement.nativeElement;
     expect(compiled.querySelector('.github-logo').href).toContain('https://github.com/celtian/ngx-app-version');
-  }));
+  });
 });
diff --git a/projects/demo/src/polyfills.ts b/projects/demo/src/polyfills.ts
diff --git a/projects/demo/src/test.ts b/projects/demo/src/test.ts
@@ -1,6 +1,5 @@
 // This file is required by karma.conf.js and loads recursively all the .spec and framework files
 
-import 'zone.js/testing';
 import { getTestBed } from '@angular/core/testing';
 import { BrowserDynamicTestingModule, platformBrowserDynamicTesting } from '@angular/platform-browser-dynamic/testing';
 

diff --git a/projects/demo/tsconfig.app.json b/projects/demo/tsconfig.app.json
@@ -4,6 +4,6 @@
     "outDir": "../../out-tsc/app",
     "types": []
   },
-  "files": ["src/main.ts", "src/polyfills.ts"],
+  "files": ["src/main.ts"],
   "include": ["src/**/*.d.ts"],
 }
diff --git a/projects/demo/tsconfig.spec.json b/projects/demo/tsconfig.spec.json
@@ -4,6 +4,6 @@
     "outDir": "../../out-tsc/spec",
     "types": ["jasmine", "node"]
   },
-  "files": ["src/test.ts", "src/polyfills.ts"],
+  "files": ["src/test.ts"],
   "include": ["src/**/*.spec.ts", "src/**/*.d.ts"],
 }
diff --git a/projects/ngx-app-version/src/lib/ngx-app-version.directive.spec.ts b/projects/ngx-app-version/src/lib/ngx-app-version.directive.spec.ts
@@ -1,4 +1,4 @@
-import { Component, ElementRef, Renderer2 } from '@angular/core';
+import { Component, ElementRef, Renderer2, provideExperimentalZonelessChangeDetection } from '@angular/core';
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { NgxAppVersionDirective } from './ngx-app-version.directive';
@@ -24,6 +24,7 @@ describe('NgxAppVersionDirective', () => {
         declarations: [TestComponent],
         imports: [NgxAppVersionDirective],
         providers: [
+          provideExperimentalZonelessChangeDetection(),
           provideAppVersion(mockOptions),
           { provide: ElementRef, useValue: {} },
           { provide: Renderer2, useValue: {} }
@@ -64,6 +65,7 @@ describe('NgxAppVersionDirective', () => {
         declarations: [TestHostComponent],
         imports: [],
         providers: [
+          provideExperimentalZonelessChangeDetection(),
           provideAppVersion(mockOptions),
           { provide: ElementRef, useValue: {} },
           { provide: Renderer2, useValue: {} }

diff --git a/projects/ngx-app-version/src/test.ts b/projects/ngx-app-version/src/test.ts
@@ -1,7 +1,5 @@
 // This file is required by karma.conf.js and loads recursively all the .spec and framework files
 
-import 'zone.js';
-import 'zone.js/testing';
 import { getTestBed } from '@angular/core/testing';
 import { BrowserDynamicTestingModule, platformBrowserDynamicTesting } from '@angular/platform-browser-dynamic/testing';