Added suggested changes from Quantstamp audit feedback. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Using `require(...)` for testing input parameters and `assert(...)` for validating invariants - Error on L71 "Maximum" needed to be changed to "Minimum"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used the Fixidity library in the smart contracts for PoolTogether. We had the contracts audited by Quantstamp, so we thought we contribute their findings upstream.
The audit report had the feedback:
require(...)for testing input parameters andassert(...)for validating invariants
Their focus was on the FixidityLib.sol contract but I've also updated the other libs to use
require.I hope this helps. Thanks for the library!
🥂