Skip to content

Conversation

yaxan
Copy link
Contributor

@yaxan yaxan commented Sep 23, 2024

Fixes inaccuracies in the kernel summations during data collection.

  • Adds extra warmup before profiling
  • Profiles entire graph execution and stores execution times to map individual operations to their time on the full trace.

@anandj91 anandj91 self-requested a review September 26, 2024 15:53
@yaxan yaxan requested review from anandj91 and removed request for anandj91 October 9, 2024 22:22
actual_time = t

with torch.profiler.profile(
activities=[torch.profiler.ProfilerActivity.CUDA, torch.profiler.ProfilerActivity.CPU]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove CPU if not used

with torch.profiler.profile(activities=[torch.profiler.ProfilerActivity.CUDA]) as prof:
if self.data_collection_mode:
with torch.profiler.profile(
activities=[torch.profiler.ProfilerActivity.CUDA, torch.profiler.ProfilerActivity.CPU]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove CPU

@yaxan yaxan merged commit 35fc1fe into main Oct 28, 2024
0 of 2 checks passed
@yaxan yaxan deleted the yazan/prediction_updates branch October 28, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants