Updated cluster commands to use platform client 0.3.1 #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michaelshin
commented
Nov 13, 2024
michaelshin
commented
- Updated the client API calls
- Fixed the service status enumeration
- Updated the credentials keys and file name as they did not match what was expected of the credentials
|
The linter is failing because it's missing the types from the libraries found in the setup.py but not in requirements-dev.txt. @anandj91 Should we add those libraries to requirements-dev.txt as well? |
anandj91
reviewed
Nov 13, 2024
| cred = refresh_centml_token(cred["refreshToken"]) | ||
|
|
||
| return cred["access_token"] | ||
| return cred["idToken"] |
There was a problem hiding this comment.
I thought I fixed all these before i made a release.
anandj91
approved these changes
Nov 13, 2024
michaelshin
deleted the
michael/update-cluster-with-platform-client-0-3-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.