[ENV VARS] Read env vars from user input

[johncalesp]

This helps with reading env vars from user input through:
export VAR=VAL or
VAR=VAL python script.py

[michaelshin]

Does the Pydantic model not pick up the env vars? It claims it does it in the documentation. See https://docs.pydantic.dev/latest/concepts/pydantic_settings/#dotenv-env-support

[johncalesp]

It throws an error:
my .env file is this

CENTML_WEB_URL=some_url
CENTML_CONFIG_PATH=/home/john/Documents/centml/platform/centml-python-client/sandbox
CENTML_CRED_FILE=credentials.json
CENTML_PLATFORM_API_URL=some_url
CENTML_FIREBASE_API_KEY=key

and I get this error:

Traceback (most recent call last):
  File "/home/john/Documents/centml/platform/centml-python-client/sandbox/endpoint.py", line 301, in <module>
    hardware_data = get_hardware_information(cluster_id, hardware_instance_id)
  File "/home/john/Documents/centml/platform/centml-python-client/sandbox/endpoint.py", line 207, in get_hardware_information
    with get_centml_client() as cclient:
  File "/usr/lib/python3.10/contextlib.py", line 135, in __enter__
    return next(self.gen)
  File "/home/john/Documents/centml/platform/centml-python-client/centml/sdk/api.py", line 68, in get_centml_client
    host=settings.CENTML_PLATFORM_API_URL, access_token=auth.get_centml_token()
  File "/home/john/Documents/centml/platform/centml-python-client/centml/sdk/auth.py", line 54, in get_centml_token
    exp_time = int(jwt.decode(cred["id_token"], options={"verify_signature": False})["exp"])
KeyError: 'id_token'

but If I do this, it works fine

CENTML_WEB_URL=some_url CENTML_CONFIG_PATH=$(pwd) CENTML_CRED_FILE=credentials.json CENTML_PLATFORM_API_URL=some_url CENTML_FIREBASE_API_KEY=key python endpoint.py

Also, another reason is the variable CENTML_CONFIG_PATH, this adds flexibility from where you call the script, since when you use github actions I don't know for sure whats the path and I don't think $(pwd) is allowed in .env file

[michaelshin]

My comment meant that the current configuration should be able to pick up the env vars if you set them like

CENTML_WEB_URL=some_url CENTML_CONFIG_PATH=$(pwd) CENTML_CRED_FILE=credentials.json CENTML_PLATFORM_API_URL=some_url CENTML_FIREBASE_API_KEY=key python endpoint.py

If it doesn't work, I think it's a bug in how we set up the configuration

[johncalesp]

So I tested with new environment and test with main branch, and does not seem to pick up the env vars.
command

(venv) ➜  centml-python-client git:(main) ✗ CENTML_WEB_URL=https://app.centml.org CENTML_CONFIG_PATH=$(pwd) CENTML_CRED_FILE=credentials.json CENTML_PLATFORM_API_URL=https://api.centml.org CENTML_FIREBASE_API_KEY=AIzaSyBXSNjruNdtypqUt_CPhB8QNl8Djfh5RXI python endpoint.py --image-url 544849402588.dkr.ecr.us-east-1.amazonaws.com/cserve-nightly:cserve-weekly-2.1.0.debug.name-cuda --hardware cuda
Traceback (most recent call last):
  File "/home/john/Downloads/centml-python-client/endpoint.py", line 656, in <module>
    hardware_data = get_hardware_information(cluster_id, hardware_instance_id)
  File "/home/john/Downloads/centml-python-client/endpoint.py", line 506, in get_hardware_information
    with get_centml_client() as cclient:
  File "/usr/lib/python3.10/contextlib.py", line 135, in __enter__
    return next(self.gen)
  File "/home/john/Downloads/centml-python-client/centml/sdk/api.py", line 68, in get_centml_client
    host=settings.CENTML_PLATFORM_API_URL, access_token=auth.get_centml_token()
  File "/home/john/Downloads/centml-python-client/centml/sdk/auth.py", line 54, in get_centml_token
    exp_time = int(jwt.decode(cred["id_token"], options={"verify_signature": False})["exp"])
KeyError: 'id_token'

Credential File

{"access_token": "eyJhbGciOiJSUzI1NiIsImtpZCI6IjhkMjUwZDIyYTkzODVmYzQ4NDJhYTU2YWJhZjUzZmU5NDcxNmVjNTQiLCJ0eXAiOiJKV1QifQ.eyJuYW1lIjoiSm9obiBDYWxkZXJvbiIsInBpY3R1cmUiOiJodHRwczovL2xoMy5nb29nbGV1c2VyY29udGVudC5jb20vYS9BQ2c4b2NKbDdWSThvSVptTkg0dlh5NHVla1ZZZHVOLVpPU292Q01JQWM3ZDNhZ049czk2LWMiLCJpc3MiOiJodHRwczovL3NlY3VyZXRva2VuLmdvb2dsZS5jb20vcGxhdGZvcm0tZGV2LTZjM2E3IiwiYXVkIjoicGxhdGZvcm0tZGV2LTZjM2E3IiwiYXV0aF90aW1lIjoxNzM3Mzg3MjY4LCJ1c2VyX2lkIjoiOXpmbVg2Q291T1QwbjV2dzBjMWVvdEZnNldZMiIsInN1YiI6Ijl6Zm1YNkNvdU9UMG41dncwYzFlb3RGZzZXWTIiLCJpYXQiOjE3MzkyOTk0NjcsImV4cCI6MTczOTMwMzA2NywiZW1haWwiOiJqb2huLmNhbGRlcm9uQGNlbnRtbC5haSIsImVtYWlsX3ZlcmlmaWVkIjp0cnVlLCJmaXJlYmFzZSI6eyJpZGVudGl0aWVzIjp7Imdvb2dsZS5jb20iOlsiMTA3NjIxMzk0MDQ3MzczNTc4MjY4Il0sImVtYWlsIjpbImpvaG4uY2FsZGVyb25AY2VudG1sLmFpIl19LCJzaWduX2luX3Byb3ZpZGVyIjoiZ29vZ2xlLmNvbSJ9fQ.QhNZRJeCTns-MlxRLFvhS9zg7aXvlHhzM2FEnaGTV9pqzZ1Av72GLfxnv-Fz4hh-eCOJKMhbQG1yKUE6JI-NuE3Dbi8KlxBIr84gOg2w29ouMJaNll_s-fMEwV7BQU6ti1UGQ3gMn6B00BnKh99Vq7RFfWVUAEB0xVtI1Fs3_fZr52d-G2-MSH4GmWyVxwxllESrfUKgk8xPg37Ms3RxxcpB2yanUUdNHPucxuPW_NEczUNRkZpTSwnuGPBV4zHGVP61Nkf8Z41RuWMJ0eDCsLTaAcnZs2RZv6NJrLILyeHjobnOYI8BNnd-b5RHebvlY126wXPNNwa91p1gJLMEDg", "expires_in": "3600", "token_type": "Bearer", "refresh_token": "AMf-vByBYs2FAbl0CAAdnBdqz1upIBc7f_95rKuuw7jCxjWSpiiZnkVg0Co665iDY3rsAE2M496haPxc-Rg_z7fj6UBBAovQrfT4YDdRVE1s0VNd50y-rQP43rOPhZJ8MTCsXglHtrK1xtsxnYdCBbLtx6CeI92EIrgqvY4wEJtXz0vBTwzl7AWHesd9s_JnADkDTokJpBtaO6qhn4aJ-zUCnVB0JzD44Bt0achrzaxhbkT181NTNOqBXuq3KR8bAqeCxjtpUKJOCAsUdWIoIZEdpTTX6QVUmaTzgXtJqFuEGYf5zjU9Z7ZoWUOAq74yCJQ6zq-mqKa7M1BPGHZpWYnX_pyjoLOQWWAgt6E6bWQs_pCIwm3mCMfWJhwj3NN28WFdM1JjP9MZSDxcEqbUZcjkvPlTdk8tg9SmHlDsvq1dEquc5u4Sx2YkdHuFHSNpKHSdqTjDvUT7", "id_token": "eyJhbGciOiJSUzI1NiIsImtpZCI6IjhkMjUwZDIyYTkzODVmYzQ4NDJhYTU2YWJhZjUzZmU5NDcxNmVjNTQiLCJ0eXAiOiJKV1QifQ.eyJuYW1lIjoiSm9obiBDYWxkZXJvbiIsInBpY3R1cmUiOiJodHRwczovL2xoMy5nb29nbGV1c2VyY29udGVudC5jb20vYS9BQ2c4b2NKbDdWSThvSVptTkg0dlh5NHVla1ZZZHVOLVpPU292Q01JQWM3ZDNhZ049czk2LWMiLCJpc3MiOiJodHRwczovL3NlY3VyZXRva2VuLmdvb2dsZS5jb20vcGxhdGZvcm0tZGV2LTZjM2E3IiwiYXVkIjoicGxhdGZvcm0tZGV2LTZjM2E3IiwiYXV0aF90aW1lIjoxNzM3Mzg3MjY4LCJ1c2VyX2lkIjoiOXpmbVg2Q291T1QwbjV2dzBjMWVvdEZnNldZMiIsInN1YiI6Ijl6Zm1YNkNvdU9UMG41dncwYzFlb3RGZzZXWTIiLCJpYXQiOjE3MzkyOTk0NjcsImV4cCI6MTczOTMwMzA2NywiZW1haWwiOiJqb2huLmNhbGRlcm9uQGNlbnRtbC5haSIsImVtYWlsX3ZlcmlmaWVkIjp0cnVlLCJmaXJlYmFzZSI6eyJpZGVudGl0aWVzIjp7Imdvb2dsZS5jb20iOlsiMTA3NjIxMzk0MDQ3MzczNTc4MjY4Il0sImVtYWlsIjpbImpvaG4uY2FsZGVyb25AY2VudG1sLmFpIl19LCJzaWduX2luX3Byb3ZpZGVyIjoiZ29vZ2xlLmNvbSJ9fQ.QhNZRJeCTns-MlxRLFvhS9zg7aXvlHhzM2FEnaGTV9pqzZ1Av72GLfxnv-Fz4hh-eCOJKMhbQG1yKUE6JI-NuE3Dbi8KlxBIr84gOg2w29ouMJaNll_s-fMEwV7BQU6ti1UGQ3gMn6B00BnKh99Vq7RFfWVUAEB0xVtI1Fs3_fZr52d-G2-MSH4GmWyVxwxllESrfUKgk8xPg37Ms3RxxcpB2yanUUdNHPucxuPW_NEczUNRkZpTSwnuGPBV4zHGVP61Nkf8Z41RuWMJ0eDCsLTaAcnZs2RZv6NJrLILyeHjobnOYI8BNnd-b5RHebvlY126wXPNNwa91p1gJLMEDg", "user_id": "9zfmX6CouOT0n5vw0c1eotFg6WY2", "project_id": "411971949855"}%

[michaelshin]

That's annoying I guess pydantic doesn't support it well.

[michaelshin]

I would change this to be the following format os.getenv(ENV_VAR, default=DEFAULT_VALUE) instead of using ors

[johncalesp]

Yeap, done

[johncalesp]

Merging, I don't know if unit test are working right now

[michaelshin]

Yeah it's a known issue all good to merge