Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

ci/github: Set SOURCE_DATE_EPOCH #24

Merged
merged 2 commits into from
Nov 17, 2023
Merged

ci/github: Set SOURCE_DATE_EPOCH #24

merged 2 commits into from
Nov 17, 2023

Conversation

cgwalters
Copy link
Member

This is important since it turns on some rpm-ostree reproducibility bits. TODO: replicate with RHTAP

@cgwalters
Copy link
Member Author

a bit surprising

@cgwalters cgwalters requested a review from lmilbaum November 7, 2023 17:57
lmilbaum
lmilbaum suggested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@lmilbaum lmilbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to move those bits to the publish-image.yml file. The CI workflow is just checking the build is successful while the publish image workflow, which is triggered after the PR is merged, is the one which pushes the image to quay.io

@cgwalters
Copy link
Member Author

Right. I guess this really gets into a larger question I have around why nothing in RHTAP (AFAICS) is dealing with SOURCE_DATE_EPOCH. I can't even find any references to it in the Tekton ecosystem in general.

@cgwalters cgwalters requested a review from lmilbaum November 8, 2023 14:55
@cgwalters
Copy link
Member Author

Anyways updated the publish-image flow too

@cgwalters
Copy link
Member Author

Ahh this needs #38

@lmilbaum
Copy link
Contributor

lmilbaum commented Nov 8, 2023

#38 merged. please rebase.

@cgwalters
Copy link
Member Author

cgwalters commented Nov 9, 2023 •
edited
Loading

OK so we merged #38 but then we merged #45 which effectively reverted it...and now the builds are broken again because quay.io pretty aggressively GCs unreferenced images...

@cgwalters cgwalters force-pushed the source-date-epoch branch 2 times, most recently from 5417bd5 to 819a49b Compare November 9, 2023 23:42
@cgwalters
ci/github: Set SOURCE_DATE_EPOCH
b7407bb 
This is important since it turns on some rpm-ostree reproducibility bits.
TODO: replicate with RHTAP
@cgwalters
ci: Re-float to builder image
23140d6 
Until something is tagging the builder image, quay.io is going to GC
older images.
@cgwalters cgwalters enabled auto-merge November 17, 2023 15:56
@cgwalters cgwalters disabled auto-merge November 17, 2023 20:28
@cgwalters cgwalters merged commit 1435c4c into CentOS:main Nov 17, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lmilbaum lmilbaum Awaiting requested review from lmilbaum

Assignees

@cgwalters cgwalters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgwalters @lmilbaum