Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple RP with scheduler backporting from 1.18.5 #1097

Conversation

Sindica
Copy link
Collaborator

@Sindica Sindica commented May 29, 2021

530 release

This code change includes back porting k8s scheduler 1.18.5 and applied the following artkos changes on top of it:
. Multi-tenancy
. VM support & vertical scaling
. Partial runtime readiness
. Scale out support: multiple resource partitions, kubeup/kubemark/proxy/perf test changes, local script for arktos up,

Sindica added 30 commits May 28, 2021 17:38
… and staging/src/k8s.io/component-base/metrics/*_test.go
codec_factory.go, codec_test.go, testing/conversion.go
…bject

Only picked up changes required to compile scheduler
- Due to Scheduler interface change.
. Pick up api violation exception only
TODO: add changes to test/integration/scheduler
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
@vinaykul
Copy link
Member

vinaykul commented Jun 3, 2021

/lgtm

I reviewed specific changes that affect Vertical Scaling and CommonInfo features, and they look fine. I'm counting on fully passing unit tests and E2E tests to ensure this huge change does not regress my earlier work.

Copy link
Collaborator

@yb01 yb01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@h-w-chen h-w-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sindica Sindica closed this Jun 3, 2021
@Sindica Sindica reopened this Jun 3, 2021
@zmn223
Copy link
Collaborator

zmn223 commented Jun 4, 2021

/lgtm

@zmn223
Copy link
Collaborator

zmn223 commented Jun 4, 2021

/approve

@centaurus-cloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenqianfzh, h-w-chen, pdgetrf, yb01, zmn223

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centaurus-cloud-bot centaurus-cloud-bot merged commit fb66dab into CentaurusInfra:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants