Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] Fix preprint state machine #10668

Draft
wants to merge 22 commits into
base: develop
Choose a base branch
from
Draft

[POC] Fix preprint state machine #10668

wants to merge 22 commits into from

Conversation

Johnetordoff
Copy link
Contributor

@Johnetordoff Johnetordoff commented Jul 15, 2024 •
edited
Loading

Purpose

Erase tech debt from old state machine implementation.

Changes

  • Standerize triggers and states using ModerationEnum
  • Separate overlapping transitions to make them more declaritive and indepenent of each other
  • Intestate state machine on model so validation works (fix MachinableMixin)
  • Write validation for before state transitions
  • Write after behavior to conform to tests.
  • ReviewActionSerializer should improve in code quality

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

@Johnetordoff Johnetordoff force-pushed the fix-preprint-state-machince2 branch 3 times, most recently from 8f38702 to fea43ec Compare July 15, 2024 23:09
@Johnetordoff Johnetordoff force-pushed the fix-preprint-state-machince2 branch 2 times, most recently from 8f5383f to 426524d Compare July 16, 2024 05:09
@Johnetordoff Johnetordoff force-pushed the fix-preprint-state-machince2 branch 6 times, most recently from a31bd96 to d7197d7 Compare July 16, 2024 17:45
@Johnetordoff Johnetordoff force-pushed the fix-preprint-state-machince2 branch 7 times, most recently from 0389f6b to 37c72e9 Compare July 18, 2024 15:42
@Johnetordoff Johnetordoff changed the title [WIP] Fix preprint state machince [POC] Fix preprint state machince Jul 18, 2024
@Johnetordoff Johnetordoff changed the title [POC] Fix preprint state machince [POC] Fix preprint state machine Jul 18, 2024
@Johnetordoff Johnetordoff force-pushed the fix-preprint-state-machince2 branch 2 times, most recently from b08a843 to 4c56d31 Compare July 18, 2024 17:50
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
9ecc89c 
 into fix-preprint-state-machince2

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  update dataverse dep revision to get changes
  Update CHANGELOG, bump version
  [CR][ENG-5681] Great Big Python Upgrade (CenterForOpenScience#10648)

# Conflicts:
#	api/actions/serializers.py
#	api/providers/workflows.py
#	api_tests/identifiers/views/test_identifier_detail.py
#	api_tests/preprints/views/test_preprint_list.py
#	api_tests/reviews/mixins/filter_mixins.py
#	osf/utils/machines.py
#	osf/utils/workflows.py
#	osf_tests/test_schema_responses.py
@Johnetordoff Johnetordoff force-pushed the fix-preprint-state-machince2 branch 3 times, most recently from 873b00f to 45ebf0e Compare July 23, 2024 15:34
@Johnetordoff Johnetordoff force-pushed the fix-preprint-state-machince2 branch 4 times, most recently from 979b51e to 6be19b8 Compare July 26, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Johnetordoff