0.23.0/no-editing-on-profile-page #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users who change their name on their user profile page do not see that there is an additional step of updating the name parts, and this has caused confusion on multiple occasions such as when Lyndsy was demoing the citation modifications and didn't realize that the name needed changing in multiple ways. This eliminates the ability for a user to make profile modifications on the profile page, and instead takes them to the settings page for such changes. I had to make some changes to the knockout which wasn't really expecting to have a situation where you would have a view-only version of the page even if the user had the capability to edit their own info. It was almost there, but there were some assumptions based on what we had currently implemented that were not correct.
|
Nice. How about "Edit your profile"? |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Force a user to go to user settings page in order to update a profile
Changes
Users who change their name on their user profile page do not see that there is an additional step of updating the name parts, and this has caused confusion on multiple occasions such as when Lyndsy was demoing the citation modifications and didn't realize that the name needed changing in multiple ways. This eliminates the ability for a user to make profile modifications on the profile page, and instead takes them to the settings page for such changes. I had to make some changes to the knockout which wasn't really expecting to have a situation where you would have a view-only version of the page even if the user had the capability to edit their own info. It was almost there, but there were some assumptions based on what we had currently implemented that were not correct.
For a logged in user, the current profile page now looks like this:
Clicking the edit this profile link will take them to:
If you aren't logged in, the profile page for a user will look like:
Side effects
I think this is relatively self-contained. As long as permissions are maintained properly, a user shouldn't be able to edit on the profile page, changes made on the user settings page should show properly in the profile page, and users who aren't the current user should still be incapable of editing another user's info. We don't have profile picture on the setting page, so I maintain the dialog box directing users to gravatar from the profile page if the user is currently logged in.