Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redistributes some of the modules related to indexing and elasticsearch.
The main reason was that we now have an
indexing
app, so it makes sense that functions that are solely concerned with index management (e.g. creating or populating an index) are moved there, while thees
app is kept for more fundamental elasticsearch business. In that vein, the module to construct anElasticsearch
instance is moved to thees
module.While moving the modules, I also split up some files that had grown beyond a practical size.
List of changes:
indexing
appes_index
andes_alias
modules into smaller modules:es_index
is split up into three modules: running aCreateIndexTask
, running aPopulateIndexTask
, and running anIndexJob
(i.e. running all tasks).es_alias
, functions related to versioning are extracted to a separate module.es
appNote for review: I did not change any code here, apart from updating imports and extracting some functions into separate modules. Since this code is all quite extensively unit-tested and git diffs for this kind of thing are usually a mess, I would recommend against trying to verify all the code changes. Just check if the list of changes makes sense.