add internal_name to service #202
Conversation
| @@ -2,6 +2,7 @@ class CreateServices < ActiveRecord::Migration | |||
| def change | |||
| create_table :services do |t| | |||
| t.string :name | |||
| t.string :internal_name | |||
There was a problem hiding this comment.
This is our first schema change since being out in the wild -- I think we might need to do this as a dedicated migration.
rheinwein
force-pushed
the
feature/add-internal-name-70098068
branch
2 times, most recently
from
5c83ef4
to
793edc5
Compare
| @@ -0,0 +1,5 @@ | |||
| class AddInternalNameToService < ActiveRecord::Migration | |||
| def change | |||
| add_column :services, :internal_name, :string | |||
There was a problem hiding this comment.
I'm not well-versed in the migration stuff, but I'm thinking that we probably also need to do some sort of data manipulation as part of this. If the user already has services in the their DB we'll want to update all those records and copy the name field to the internal_name field. Not sure if that logic is appropriate to put in the migration file or if it goes someplace else. Maybe @alexwelch can weigh-in.
rheinwein
force-pushed
the
feature/add-internal-name-70098068
branch
from
793edc5
to
3faff8b
Compare
| @@ -29,6 +29,7 @@ class Service < ActiveRecord::Base | |||
| serialize :volumes, Array | |||
|
|
|||
| before_save :resolve_name_conflicts | |||
| before_create :set_internal_name | |||
There was a problem hiding this comment.
I think the significance of this line is definitely worth exercising in your tests. Specifically the fact that this internal_name is not updated on subsequent changes (updates)... Hit me up if you want me to ellaborate
There was a problem hiding this comment.
Updated to add another testing case.
rheinwein
force-pushed
the
feature/add-internal-name-70098068
branch
from
3faff8b
to
98b3dd0
Compare
|
👍 |
1 similar comment
|
👍 |
rheinwein
force-pushed
the
feature/add-internal-name-70098068
branch
from
98b3dd0
to
10c7bc6
Compare
rheinwein
force-pushed
the
feature/add-internal-name-70098068
branch
from
10c7bc6
to
ae651c9
Compare
We want users to be able to update service.name, but that value is used within the unit file. This introduces a new field on the service called 'internal_name' which is immutable and will be used in places where a string is used a unique identifier.
[finishes #70098068]