adding the ability to redeploy a remote deployment #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dharmamike
force-pushed
the
feature/redeploy-83325574
branch
2 times, most recently
from
3e13e44
to
1a7f015
Compare
Signed-off-by: Gary Paige <gary@theoryblister.com>
dharmamike
force-pushed
the
feature/redeploy-83325574
branch
from
1a7f015
to
23ec15e
Compare
| raise 'deployment not found' | ||
| else | ||
| raise response.body['message'] | ||
| end | ||
| end |
There was a problem hiding this comment.
The methods in this service weren't properly dealing with calls to the agent that might result in a 500 status. As a result, in cases where the method attempted to create a RemoteDeployment from the http response, a NoMethodError would be raised due to an attempt to call message= on the new RemoteDeployment instance (this is because the 500 errors from the agent include a JSON body with a "method" attribute). This error has actually shown up in the UI and we didn't know why. This explains it, and this new #handle_agent_response method fixes it, propagating the error message up to the local agent error handler.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gary Paige gary@theoryblister.com