-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Polkadot v1.2. to v1.4 upgrade #437
Conversation
ff18af0
to
2b82078
Compare
ff03d9c
to
cee1d9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@metricaez @Aideepakchaudhary Please fix the conflicts.
@@ -566,6 +571,7 @@ parameter_types! { | |||
pub const BondingDuration: sp_staking::EraIndex = 3; | |||
pub const SlashDeferDuration: sp_staking::EraIndex = 2; | |||
pub const RewardCurve: &'static PiecewiseLinear<'static> = &REWARD_CURVE; | |||
pub const MaxExposurePageSize: u32 = 512; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayushmishra2005 take a look at this 512 value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aie0 Please see my comment here #437 (comment). MaxNominatorRewardedPerValidator
was renamed to MaxExposurePageSize
as a part of paritytech/polkadot-sdk#1189. Since MaxNominatorRewardedPerValidator
was set to 512, so MaxExposurePageSize
should be set to 512. There was no recommendation to lower down its value.
I made this change
1731138
to
b78a37e
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9100662 | Triggered | Generic High Entropy Secret | b78a37e | node/service/chain-specs/example.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
I tried squashing in this PR to convert into single commit. That went wrong unfortunately. Since I had created backup before performing squash, so I just raised new PR #457 from new branch. Closing the PR. |
Description
This PR is upgrading Runtime's and Node's dependencies from Polkadot-SDK release
v1.2.0
to1.4.0
Notes
Relevant upgrade's notes and comments.
Performed the migration of three FRAME pallets:
pallet_nomination_pools
,pallet_staking
, andpallet_grandpa
, and modified the method of passing the wasm_binary parameter in the chain_spec file.Please validate the following values that we have hardcoded in the code:
Breaking changes:
Kindly refer to the official Polkadot release report for further details: Polkadot v1.4.0
Polkadot release analysis : Polkadot v1.4.0 analysis
Process
spec_ver
for bothtestnet
andmainnet
Runtime.TBD
Codebase Upgrade Acceptance Criteria
cargo check
passescargo test
passescargo build
on-- release
profile correctly buildstry-runtime
andruntime-benchmarks
features compileblock-production
config file generates blocks.Runtime & Node Upgrade Acceptance Criteria
Runtime upgrade works on Zombienet
Node upgrade works on Zombienet
Runtime upgrade works on Chopsticks
Try-runtime passes with no pending migrations
<!--- PR TEMPLATE CONTENT STARTS HERE -->
Types of Changes
Please select the branch type you are merging and fill in the relevant template.
<!--- Check the following box with an x if the following applies: -->
Fix or Feature
<!--- Check the following box with an x if the following applies: -->
Types of Changes
<!--- What types of changes does your code introduce? -->
Migrations and Hooks
<!--- Check the following box with an x if the following applies: -->
on_initialize
on_finalize
Checklist for Fix or Feature
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->
spec_version
has been incremented.network-relayer
's events have been updated according to the blockchain events if applicable.Checklist for Hotfix
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->
spec_version
has been incremented.dev
has been created.staging
has been created.network-relayer
's events have been updated according to the blockchain events if applicable.Checklist for Release
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->