-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collecting validator verification key in Substrate - generic way #463
base: dev
Are you sure you want to change the base?
Conversation
20849c0
to
0a21d03
Compare
runtime/cere-dev/src/lib.rs
Outdated
pallet_grandpa::migrations::MigrateV4ToV5<Runtime>, | ||
pallet_ddc_verification::migrations::v1::MigrateToV1<Runtime>, | ||
); | ||
type Migrations = (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade should be merged and deployed to DEVNET after the #457 is deployed. That's why I'm removing the related migrations here.
use crate::KEY_TYPE; | ||
app_crypto!(sr25519, KEY_TYPE); | ||
use crate::DAC_VERIFICATION_KEY_TYPE; | ||
app_crypto!(sr25519, DAC_VERIFICATION_KEY_TYPE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a similar pattern in authority-discovery
, babe
, and such. But they define AuthorityId
as an alias for the Public
made by the macros (https://github.com/paritytech/polkadot-sdk/blob/c8d2251cafadc108ba2f1f8a3208dc547ff38901/substrate/primitives/authority-discovery/src/lib.rs#L35). Should we do the same for validators accounts or the AccountId
suits for us?
536cebb
to
720b308
Compare
Description
This PR removes the excessive
set_current_validator
extrinsic and applies the generic approach for collecting the verification key from the keystore as it is done in the substrate source codeTypes of Changes
Please select the branch type you are merging and fill in the relevant template.
Fix or Feature
Types of Changes
Migrations and Hooks
on_initialize
on_finalize
Checklist for Fix or Feature
spec_version
has been incremented.network-relayer
's events have been updated according to the blockchain events if applicable.Checklist for Hotfix
spec_version
has been incremented.dev
has been created.staging
has been created.network-relayer
's events have been updated according to the blockchain events if applicable.Checklist for Release