Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ddc validator unit tests #83

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Feature/ddc validator unit tests #83

merged 4 commits into from
Sep 22, 2023

Conversation

Raid5594
Copy link
Contributor

@Raid5594 Raid5594 commented Sep 1, 2023

  • write unit tests for pallet ddc validator
  • fix codebase due to bugs revealed by testing

khssnv
khssnv reviewed Sep 1, 2023
View reviewed changes
pallets/ddc-validator/src/lib.rs Outdated Show resolved Hide resolved
pallets/ddc-validator/src/tests.rs Outdated Show resolved Hide resolved
khssnv
khssnv previously approved these changes Sep 4, 2023
View reviewed changes
pallets/ddc-validator/src/lib.rs Outdated Show resolved Hide resolved
@Raid5594 Raid5594 marked this pull request as ready for review September 21, 2023 14:43
@Raid5594 Raid5594 merged commit 800d998 into dev Sep 22, 2023
2 checks passed
@Raid5594 Raid5594 deleted the feature/ddc-validator-unit-tests branch September 22, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRamanenkau MRamanenkau MRamanenkau approved these changes

@khssnv khssnv khssnv left review comments

@yahortsaryk yahortsaryk Awaiting requested review from yahortsaryk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Raid5594 @khssnv @MRamanenkau