Temporary fix for the bucket storage version selection #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khssnv
force-pushed
the
fix/wrong-version-selection
branch
from
eff0b46 to
60b1a26
Compare
spoluyan
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following check unexpectedly returns true for a block with a bucket storage layout
v54100.cere-squid-indexer/src/processors/ddcBucketsProcessor.ts
Line 35 in 635b47f
The patch replaces
.is(block)calls with spec versions comparisons. This fixes the problem with the wrong bucket storage layout selection. At the same time we are losing an ability to detect if an incoming block has an unsupported (future) version of the storage and this patch should be reverted as soon as the.is(block)check fixed.I've also checked if other processors affected and have not found the same problem with
storage.system.account.v266.is(block)inCereBalancesProcessor.