Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate jrsonnet-evaluator and stdlib implementation #82

Closed
wants to merge 45 commits into from
Closed

Separate jrsonnet-evaluator and stdlib implementation #82

wants to merge 45 commits into from

Conversation

CertainLach
Copy link
Owner

No description provided.

@CertainLach
doc: add patreon link
277df8e
@CertainLach
ci: remove outdated build
d748c85 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
refactor!: remove outdated ast pretty-printer
146d9d9 
It had no practical use, because it was not comment-preserving
There is in-progress version based on rowan parser, however it shares
no code with current implementation

BREAKING CHANGE: It is no longer possible to build jrsonnet-fmt

Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
refactor(parser)!: remove intrinsic syntax
5a21a2e 
There was special support to refer to native functions for stdlib, as
otherwise `std.native` was not implementable.
However, now evaluator contains support for fancy builtins, and it is
possible to reimplement standard library without any parser magic.

BREAKING CHANGE: This syntax no longer works: $intrinsic(name),
$intrinsicId, $intrinsicThisFile

Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
feat(interner): make more functions const
34a152f 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
refactor(evaluator)!: remove standard library
ab6ba99 
Implementation will be moved to jrsonnet-stdlib crate

BREAKING CHANGE: `State::with_stdlib` was removed

Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
refactor(stdlib): implement as a standalone crate
6d7ca68 
New builtins system allows to split standard library to standalone crate

Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
fix(evaluator): unnamed_len conflict with unnamed_iter
907d6da 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
feat(evaluator): function signature help
50ca1d2 
When calling functions with wrong arguments, evaluator will now suggest
correct function signature

Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
style: apply clippy suggestions
06fa714 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
refactor(cli): move to split stdlib
dde7eda 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
refactor(libjsonnet): move to split stdlib
41db4d5 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
feat: ContextBuilder
21a5131 
Helper for fancier building of user contexts

Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
feat(evaluator): IndexableMap::slice helper
3ee61c4 
Previously `slice` method was only in `ArrayVal`, and for strings it
needed to be implemented manually

Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
build: regenerate lockfile
b797bad 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
build: regenerate lockfile
593731d 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
ci: remove outdated nix flake
cfd533f 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
fix(cli): gc stats were always printed
6eba9c3 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
fix(stdlib): std.trace should be lazy
68c8ac0 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
refactor: keep source code alongside source path
4ad9956 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
fix(parser): allow trailing comma before forspec in object
673ea5e 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
perf: only cache gets in top-level object
b305ce3 
Deep cache only has sense in presence of standalone self, and most of
the time it only takes unnecessary space, and takes time to fill/rehash
the cache map.

Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
perf: reimplement AST codegen
0831da3 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
perf: implement std.findSubstr in native
f51b87e 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
perf: remove allocation on empty string concat
a586993 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
perf: implement std.{startsWith, endsWith} in native
4c21363 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
test: update for split stdlib
aa97bc0 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
style: fix clippy warnings
f22b934 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach CertainLach added the enhancement New feature or request label Aug 7, 2022
@CertainLach CertainLach added this to the v0.5.0 milestone Aug 7, 2022
@CertainLach
build: regenerate lockfile
3a6a304 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
fix: remove unnecessary reference
a5bf806 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
style: fix trailing newline
f2fefaf 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
JarvisCraft
JarvisCraft approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@JarvisCraft JarvisCraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although there is a number of small fixes and a pack of typo/phrasing fixes.

bindings/jsonnet/src/val_extract.rs Outdated Show resolved Hide resolved
bindings/jsonnet/src/val_extract.rs Outdated Show resolved Hide resolved
bindings/jsonnet/src/val_extract.rs Outdated Show resolved Hide resolved
bindings/jsonnet/src/val_extract.rs Outdated Show resolved Hide resolved
bindings/jsonnet/src/val_make.rs Outdated Show resolved Hide resolved
crates/jrsonnet-stdlib/src/math.rs Outdated Show resolved Hide resolved
crates/jrsonnet-stdlib/src/sort.rs Outdated Show resolved Hide resolved
crates/jrsonnet-stdlib/src/sort.rs Outdated Show resolved Hide resolved
crates/jrsonnet-stdlib/src/types.rs Show resolved Hide resolved
tests/src/lib.rs Outdated Show resolved Hide resolved
@JarvisCraft JarvisCraft self-requested a review September 15, 2022 11:16
JarvisCraft
JarvisCraft requested changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@JarvisCraft JarvisCraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good although there is a number of small fixes and enhancements

@CertainLach CertainLach mentioned this pull request Sep 17, 2022
Closed
CertainLach and others added 8 commits September 18, 2022 10:24
@CertainLach @JarvisCraft
refactor: trivial code review suggestions
097494e 
Co-authored-by: Petr Portnov | PROgrm_JARvis <gh@progrm-jarvis.ru>
@CertainLach
fix: int rendering in format should operate floats
e8ba764 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
feat: impl ArgsLike for Vec<Val>
420d09a 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
doc: builtin trait
1178a0b 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
feat: allow unnamed builtin arguments
afca252 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
style: fix clippy warnings
70f3783 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
doc: review issues
ff3e2c8 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach
Merge remote-tracking branch 'origin/master' into split-stdlib
c39582b 
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach CertainLach deleted the split-stdlib branch October 17, 2022 18:43
CertainLach added a commit that referenced this pull request Oct 17, 2022
@CertainLach
Merge pull request #84 from CertainLach/split-stdlib
b8bef13 
 Separate jrsonnet-evaluator and stdlib implementation #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JarvisCraft JarvisCraft JarvisCraft approved these changes

Assignees

@CertainLach CertainLach

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@CertainLach @JarvisCraft