Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Code refactoring #198

Merged
merged 29 commits into from
Jul 21, 2021
Merged

♻️ Code refactoring #198

merged 29 commits into from
Jul 21, 2021

Conversation

amalsyahmi
Copy link
Contributor

@amalsyahmi amalsyahmi commented Jul 9, 2021

Description

  • Moving footer from home-card to home-footer component, without affecting UI
  • Code refactoring
    • Remove unused html and scss code
    • Remove unused component
    • Eliminate duplicated function and reduce duplication on code
    • Reduce cognitive complexity in a single function
    • Simplifying code
  • Reduce image size in assets
  • Change base URL for typescript import and scss @use
  • Moving reusable components into 'shared/components' directory

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@amalsyahmi amalsyahmi changed the title Code refactoring ♻️ Code refactoring Jul 19, 2021
@amalsyahmi amalsyahmi self-assigned this Jul 19, 2021
@amalsyahmi amalsyahmi added the chore Maintenance label Jul 19, 2021
@amalsyahmi amalsyahmi marked this pull request as ready for review July 19, 2021 02:39
Copy link
Contributor

@hansheng0512 hansheng0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The rename image function is not working, the backend branch Im using is v2alpha.
    4

  2. Seems these model alignment got problem.

2
1
3

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.9% 0.9% Duplication

@amalsyahmi
Copy link
Contributor Author

Regarding the first issue, it seems like the problem comes from backend.
I've created an issue in classifai backend repo CertifaiAI/classifai#468

@hansheng0512 hansheng0512 self-requested a review July 21, 2021 02:57
Copy link
Contributor

@hansheng0512 hansheng0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All functions working as expected.

@hansheng0512 hansheng0512 merged commit 2d7b7a0 into main Jul 21, 2021
@hansheng0512 hansheng0512 deleted the code-refactoring branch July 21, 2021 08:34
fariskamaludin-skymind pushed a commit to CertifaiAI/classifai that referenced this pull request Jul 21, 2021
@codenamewei codenamewei changed the title ♻️ Code refactoring ♻️ Code refactoring Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants