Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guiding cross line, add delete project confirmation, fix undo-redo button & fix grammar #201

Merged
merged 7 commits into from
Jul 30, 2021

Conversation

amalsyahmi
Copy link
Contributor

@amalsyahmi amalsyahmi commented Jul 27, 2021

Description

  • Add guiding cross line for more effective bounding box labelling.
2021-07-27.15-58-23.mp4
  • Fix undo redo button that doesn't work previously.

  • Fix grammar (is -> was).

image

  • Ask user confirmation when user want to delete a project.

image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@amalsyahmi
Copy link
Contributor Author

Please ignore failed code analysis. Will fixed in the next PR in code-refactoring branch

Copy link
Contributor

@hansheng0512 hansheng0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to use other color because the bbox color are in yellow already.
Capture

@devenyantis
Copy link
Contributor

devenyantis commented Jul 28, 2021

Suggest to use other color because the bbox color are in yellow already.
Capture

yes. agree with this.

For me,

  • And the thickness can be reduced as well. For image with lots of annotation, can look messy.
  • Provide a way to toggle on and off the guiding lines. Like a button.

@amalsyahmi
Copy link
Contributor Author

@hansheng0512 @devenyantis
Changes:

  • Change guiding lines color from yellow to red (Classifai color code).
  • Add toggle button to switch on and off the guiding lines.
2021-07-29.11-11-38.mp4

hansheng0512
hansheng0512 previously approved these changes Jul 29, 2021
Copy link
Contributor

@hansheng0512 hansheng0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@devenyantis devenyantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the toggle button should be under the bounding box. So it will be close to the bounding box button. And want to keep the info at the end.

@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
13.7% 13.7% Duplication

@amalsyahmi
Copy link
Contributor Author

Changes:

  • Change position of toggle button under the bounding box button.

@devenyantis devenyantis merged commit f5d24f5 into main Jul 30, 2021
@devenyantis devenyantis deleted the amal_fix branch July 30, 2021 07:22
fariskamaludin-skymind pushed a commit to CertifaiAI/classifai that referenced this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants