Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎇 Add in tutorial list #215

Merged
merged 10 commits into from
Nov 24, 2021
Merged

🎇 Add in tutorial list #215

merged 10 commits into from
Nov 24, 2021

Conversation

yipkhenlai
Copy link
Contributor

Description

tutorial_list

Tutorial list added for user reference.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@yipkhenlai yipkhenlai added the uidesign Changes on UI/UX label Nov 2, 2021
@devenyantis
Copy link
Contributor

image

The writing is overflowing.

@yipkhenlai
Copy link
Contributor Author

image

The writing is overflowing.

@devenyantis Interesting, I will try to check out the bug

@yipkhenlai
Copy link
Contributor Author

@devenyantis adjusted the container size, try to see if the overflowing problem still persist

@devenyantis
Copy link
Contributor

image
It's not centered. Maybe a few pointer to help.

image

I think that is because you wrap the string by itself with this div. So, it will place the text according to the position in the box. Which is centered horizontal only.

Probably, few ways to solve it is use heading tag and apply css to center it OR very simple way is not to hard code the height of the box.

@yipkhenlai
Copy link
Contributor Author

@devenyantis Hi, I have made the height and width dynamic, please try it

@devenyantis
Copy link
Contributor

image
It seems like you only change height to min-height. No change on my side still not centered vertically.

@yipkhenlai
Copy link
Contributor Author

@devenyantis I added vertical align, see if it fix the issue

@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devenyantis devenyantis merged commit f7ae26f into main Nov 24, 2021
@devenyantis devenyantis deleted the ken_statistic_tutorial branch November 24, 2021 07:50
fariskamaludin-skymind pushed a commit to CertifaiAI/classifai that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority uidesign Changes on UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants