Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎇 Open and close tab by clicking icon #216

Merged
merged 3 commits into from
Nov 17, 2021
Merged

🎇 Open and close tab by clicking icon #216

merged 3 commits into from
Nov 17, 2021

Conversation

yipkhenlai
Copy link
Contributor

Description

togglebyclicktab

Ease open and close tab action

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@yipkhenlai yipkhenlai added enhancement New feature or request low priority labels Nov 2, 2021
@yipkhenlai yipkhenlai self-assigned this Nov 2, 2021
@devenyantis
Copy link
Contributor

Nice. But I think the 'X' close button should still be there.
Maybe put the button smaller.
It will provide a visual guide for user

@yipkhenlai
Copy link
Contributor Author

Nice. But I think the 'X' close button should still be there. Maybe put the button smaller. It will provide a visual guide for user

@devenyantis Agree, I will add back the close button

@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yipkhenlai
Copy link
Contributor Author

toggletab

@devenyantis Hi Deven, the behavior will be like this now.

@devenyantis devenyantis merged commit 4bb8f1a into main Nov 17, 2021
@devenyantis devenyantis deleted the toggle_tab branch November 17, 2021 15:28
fariskamaludin-skymind pushed a commit to CertifaiAI/classifai that referenced this pull request Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants