Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Add shift canvas when enlarge #226

Merged
merged 2 commits into from
Dec 10, 2021
Merged

♻️ Add shift canvas when enlarge #226

merged 2 commits into from
Dec 10, 2021

Conversation

yipkhenlai
Copy link
Contributor

Description

Add shift canvas feature for user to navigate the canvas when in zoom mode. Two key events were added for this feature, both key events do not need to be held press, they only need to press once to activate it.

  1. ctrl key: To deactivate draw function, and activate drag and scroll function
  2. x or X key: To activate back draw function, and deactivate drag and scroll function. The reason for using capitalize X too is to avoid users accidentally clicking caps lock and this key event becomes not function.

shift

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@yipkhenlai yipkhenlai added the enhancement New feature or request label Dec 9, 2021
@yipkhenlai yipkhenlai self-assigned this Dec 9, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants