Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor label color assign #228

Merged
merged 5 commits into from
Dec 13, 2021
Merged

Conversation

yipkhenlai
Copy link
Contributor

@yipkhenlai yipkhenlai commented Dec 12, 2021

Description

Solve label color service not assign color separately for different projects. Refactor code for color and region property adjusts automatically for existing labels in the canvas when an unwanted label in the column is deleted.

Fixes #535

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Lai Yip Khen added 2 commits December 13, 2021 01:17
# Conflicts:
#	src/components/image-labelling/image-labelling-segmentation/image-labelling-segmentation.component.ts
@yipkhenlai yipkhenlai added the bug Something isn't working label Dec 12, 2021
@yipkhenlai yipkhenlai self-assigned this Dec 12, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devenyantis devenyantis merged commit 51de059 into main Dec 13, 2021
@devenyantis devenyantis deleted the refactor_label_color_assign branch December 13, 2021 01:54
fariskamaludin-skymind pushed a commit to CertifaiAI/classifai that referenced this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants