Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sh empty folder #226

Merged
merged 4 commits into from
Nov 22, 2020
Merged

Sh empty folder #226

merged 4 commits into from
Nov 22, 2020

Conversation

toh-sie-hung
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #223

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@toh-sie-hung toh-sie-hung added the fix done fixing label Nov 19, 2020
@toh-sie-hung
Copy link
Contributor Author

Fixes the import empty folder problem. Once user import empty folder, the screen will back to labelling tool screen. Nothing new image will add and wont have message pop up. Able work on my laptop.

@codenamewei codenamewei changed the base branch from v1.1.0 to main November 19, 2020 13:58
@codenamewei codenamewei changed the base branch from main to v1.1.0 November 19, 2020 13:59
@@ -320,8 +320,13 @@ public static void processFolder(@NonNull Integer projectID, @NonNull File rootP
totalFilelist.addAll(files);
}
}

for(File f2 : totalFilelist)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove the println command which is suppose for debugging @toh-sie-hung
else in the long run the command prompt output will have random messages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, forget to remove it. Thx for checking

java.util.List<File> checkFileFormat = FileHandler.processFolder(rootFolder, fileExtension);

if(checkFileFormat.isEmpty() != true)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these operation happens in ImageHandler.processFolder(projectID, rootFolder); too

running it two times will cause the running time to massively increase, recommend to keep this file as how it was

@toh-sie-hung

@codenamewei
Copy link
Contributor

Advise changing in ImageHandler.java L 258

if(filesCollection.isEmpty())
        {
            loader.reset(FileSystemStatus.WINDOW_CLOSE_DATABASE_NOT_UPDATED);
            return;
        }

Screenshot 2020-11-19 223715

@codenamewei codenamewei linked an issue Nov 19, 2020 that may be closed by this pull request
@toh-sie-hung
Copy link
Contributor Author

okay, noted.

@toh-sie-hung
Copy link
Contributor Author

I just moved the code from toolfolderselector file to imagehandle file

Copy link
Contributor

@codenamewei codenamewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now.

@codenamewei codenamewei merged commit 6b7b59c into v1.1.0 Nov 22, 2020
@codenamewei codenamewei deleted the sh_empty_folder branch November 22, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix done fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classifai screen stuck when import empty folder
2 participants