-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sh empty folder #226
Sh empty folder #226
Conversation
Fixes the import empty folder problem. Once user import empty folder, the screen will back to labelling tool screen. Nothing new image will add and wont have message pop up. Able work on my laptop. |
@@ -320,8 +320,13 @@ public static void processFolder(@NonNull Integer projectID, @NonNull File rootP | |||
totalFilelist.addAll(files); | |||
} | |||
} | |||
|
|||
for(File f2 : totalFilelist) | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove the println command which is suppose for debugging @toh-sie-hung
else in the long run the command prompt output will have random messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, forget to remove it. Thx for checking
java.util.List<File> checkFileFormat = FileHandler.processFolder(rootFolder, fileExtension); | ||
|
||
if(checkFileFormat.isEmpty() != true) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these operation happens in ImageHandler.processFolder(projectID, rootFolder);
too
running it two times will cause the running time to massively increase, recommend to keep this file as how it was
Advise changing in ImageHandler.java L 258
|
okay, noted. |
I just moved the code from toolfolderselector file to imagehandle file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well now.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #223
Type of change
Please delete options that are not relevant.
Tested on?
Checklist: