Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading bug fix for #302 #304

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Loading bug fix for #302 #304

merged 1 commit into from
Feb 11, 2021

Conversation

codenamewei
Copy link
Contributor

@codenamewei codenamewei commented Feb 11, 2021

Description

Hi @kengeSkyMind , for this error fix, due to the structure of v1, its hardly reproducible.
it's very much seen in v2

Can you just run a simple test , focusing on loading project, importing project, reload project, delete some images
try with project of

  • 0 image
  • 1 image
  • a set of images (50 - 300)
    to see if anything behave weird from how it should work

if none, do merge and delete this branch.

Please refer to bug #302

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@codenamewei codenamewei added the bug Something isn't working label Feb 11, 2021
@codenamewei codenamewei self-assigned this Feb 11, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@kengeSkyMind kengeSkyMind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran a few simple test including the ones that you mentioned, looks good

@kengeSkyMind kengeSkyMind merged commit fc8deb1 into main Feb 11, 2021
@kengeSkyMind kengeSkyMind deleted the cw_load_bug_fix_v1 branch February 11, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project loading resulted in empty project (while images exist) due to code structure
2 participants