Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug fix for #437 #460

Merged
merged 4 commits into from
Jul 5, 2021
Merged

🐛 Bug fix for #437 #460

merged 4 commits into from
Jul 5, 2021

Conversation

codenamewei
Copy link
Contributor

@codenamewei codenamewei commented Jul 5, 2021 •
edited
Loading

Description

Labels will be check for spaces " " and "\r" and replace with "" (nothing)

person 1 -> person1
person 2\r->person2

Type of change

Please delete options that are not relevant.

  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Example: REST API changes)

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged
  • CHANGELOG.md has been updated
  • Update Gitbook REST API Page

@codenamewei codenamewei added the bug Something isn't working label Jul 5, 2021
@codenamewei codenamewei self-assigned this Jul 5, 2021
@codenamewei codenamewei marked this pull request as ready for review July 5, 2021 05:05
@codenamewei codenamewei changed the title Bug fix for #437 🐛 Bug fix for #437 Jul 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

hansheng0512
hansheng0512 approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@hansheng0512 hansheng0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work as expected

@hansheng0512 hansheng0512 linked an issue Jul 5, 2021 that may be closed by this pull request
Label Name Ending with Unrelated Character \r #437
Closed
@hansheng0512 hansheng0512 merged commit 7f5bdbf into v2_alpha Jul 5, 2021
@hansheng0512 hansheng0512 deleted the cw_labelfix branch July 5, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansheng0512 hansheng0512 hansheng0512 approved these changes

Assignees

@codenamewei codenamewei

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label Name Ending with Unrelated Character \r
2 participants
@codenamewei @hansheng0512