-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactor code on Image Handling and Integrate OpenCV Java #464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ken479
also look through these and try to solve most of it
https://sonarcloud.io/project/issues?id=CertifaiAI_classifai&pullRequest=464&resolved=false&types=CODE_SMELL
Hi @codenamewei , I will look into it and solve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the same as the #462, @ken479 you can proceed to close that pr. Thanks!
classifai-core/src/main/java/ai/classifai/data/type/image/ImageData.java
Show resolved
Hide resolved
classifai-core/src/main/java/ai/classifai/util/data/ImageHandler.java
Outdated
Show resolved
Hide resolved
classifai-core/src/main/java/ai/classifai/database/annotation/AnnotationVerticle.java
Outdated
Show resolved
Hide resolved
Noted. Thanks. |
classifai-core/src/main/java/ai/classifai/data/type/image/WebpImageData.java
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Integrated OpenCV Java into Classifai to support Webp image and other image types. Add in WebpImageData file. Add in "webp" in allowed file types and base64Header in ImageFileType. Refactor codes in ImageHandler and make ImageData as an abstract class to provide a layer of screening on Image types and make ImageData more organized to be used in ImageHandler.
Type of change
Please delete options that are not relevant.
Tested on?
Checklist: