Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor code on Image Handling and Integrate OpenCV Java #464

Merged
merged 8 commits into from
Jul 9, 2021

Conversation

yipkhenlai
Copy link
Contributor

Description

Integrated OpenCV Java into Classifai to support Webp image and other image types. Add in WebpImageData file. Add in "webp" in allowed file types and base64Header in ImageFileType. Refactor codes in ImageHandler and make ImageData as an abstract class to provide a layer of screening on Image types and make ImageData more organized to be used in ImageHandler.

Type of change

Please delete options that are not relevant.

  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Example: REST API changes)

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged
  • CHANGELOG.md has been updated
  • Update Gitbook REST API Page

@yipkhenlai yipkhenlai self-assigned this Jul 8, 2021
Copy link
Contributor

@codenamewei codenamewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yipkhenlai
Copy link
Contributor Author

hi @ken479

also look through these and try to solve most of it
https://sonarcloud.io/project/issues?id=CertifaiAI_classifai&pullRequest=464&resolved=false&types=CODE_SMELL

Hi @codenamewei , I will look into it and solve it.

Copy link
Contributor

@yinchuangsum yinchuangsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the same as the #462, @ken479 you can proceed to close that pr. Thanks!

@yipkhenlai
Copy link
Contributor Author

These are the same as the #462, @ken479 you can proceed to close that pr. Thanks!

Noted. Thanks.

@sonarcloud
Copy link

sonarcloud bot commented Jul 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codenamewei codenamewei linked an issue Jul 9, 2021 that may be closed by this pull request
@codenamewei codenamewei merged commit 722634e into v2_alpha Jul 9, 2021
@codenamewei codenamewei deleted the ken_ImageHandling branch July 9, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some jpg file fail to load
3 participants