Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From classifai_frontend to classifai's webroot - 🐛 Fix lazy loading bug when loading image thumbnail #484

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

fariskamaludin-skymind
Copy link
Contributor

This is an automatically created PR 🤖🤖

@devenyantis
Copy link
Contributor

@amalsyahmi-certifai

What's the behavior of the bug?

@amalsyahmi
Copy link
Contributor

@amalsyahmi-certifai

What's the behavior of the bug?

The frontend keep request the same thumbnails although all the thumbnails have been loaded.

2021-08-06.11-15-52_Trim.mp4

@codenamewei codenamewei linked an issue Aug 6, 2021 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@codenamewei codenamewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this before the prior release hence opened an issue, marked it as done, and updated the changelog too

Fixed in the latest PR #484
Screenshot 2021-08-06 at 7 27 50 PM

💯

@devenyantis devenyantis merged commit aaa98a1 into v2_alpha Aug 9, 2021
@devenyantis devenyantis deleted the faris_auto_pr branch August 9, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of images loaded more than existing images in folder
4 participants