Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎇 API to terminate classifai #496

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

codenamewei
Copy link
Contributor

@codenamewei codenamewei commented Aug 19, 2021

Description

As discussion, i crafted an API to close classifai with a pause of 1 second

PUT http://localhost:{port}/v2/close

Let me know if any changes needed thanks.
For example do we need the pause to be longer, or no pause at all. from sending the response back to terminate the program.

@devenyantis , this is to allow electron app to close backend when initiate from frontend
rather than the way how its initiated from backend now.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Example: REST API changes)

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged
  • CHANGELOG.md has been updated
  • Update Gitbook REST API Page

@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hansheng0512
Copy link
Contributor

@codenamewei
Thanks, will test it later

@hansheng0512 hansheng0512 merged commit 2ccbc2f into v2_alpha Aug 23, 2021
@devenyantis devenyantis deleted the cw_close_classifai branch August 26, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants