-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Remove JsonObject from return value #505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments here. I've only put them on the first place I noticed something, even when it applies to multiple places.
classifai-core/src/main/java/ai/classifai/action/DeleteProjectData.java
Outdated
Show resolved
Hide resolved
classifai-core/src/main/java/ai/classifai/action/DeleteProjectData.java
Outdated
Show resolved
Hide resolved
classifai-core/src/main/java/ai/classifai/database/portfolio/PortfolioDB.java
Show resolved
Hide resolved
classifai-core/src/main/java/ai/classifai/database/portfolio/PortfolioDB.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments. Again they apply in a few cases, but I didn't put them everywhere, as it is pretty obvious where the same pattern repeats.
classifai-core/src/main/java/ai/classifai/action/ProjectExport.java
Outdated
Show resolved
Hide resolved
classifai-core/src/main/java/ai/classifai/action/parser/PortfolioParser.java
Outdated
Show resolved
Hide resolved
classifai-core/src/main/java/ai/classifai/action/parser/ProjectParser.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should be able to use the object mapper in a few more places to deserialize directly, instead of manually pulling data from a JsonObject or JsonArray
classifai-core/src/main/java/ai/classifai/action/parser/ProjectParser.java
Outdated
Show resolved
Hide resolved
classifai-core/src/main/java/ai/classifai/action/parser/ProjectParser.java
Outdated
Show resolved
Hide resolved
classifai-core/src/main/java/ai/classifai/util/collection/ConversionHandler.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Some return values are changed. Some remain as json object. Also added steps to handle fail cases to map the functionality of frontend.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Tested on?
Checklist: