Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a thorough refactoring of the global state, accessed via static methods.
Because global state by its very nature can be accessed from everywhere, it introduces implicit flows and makes circular dependencies trivial.
In this pull request those dependencies have been made explicit, and the circular dependencies have been made obvious.
There is still more cleanup necessary, but this PR is huge already.
This doesn't introduce any new functionality, it is mostly structurally different, but we need to check if anything has broken from this unraveling.