Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (most) Global State #509

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

treo
Copy link
Collaborator

@treo treo commented Oct 9, 2021

This is a thorough refactoring of the global state, accessed via static methods.

Because global state by its very nature can be accessed from everywhere, it introduces implicit flows and makes circular dependencies trivial.

In this pull request those dependencies have been made explicit, and the circular dependencies have been made obvious.

There is still more cleanup necessary, but this PR is huge already.

This doesn't introduce any new functionality, it is mostly structurally different, but we need to check if anything has broken from this unraveling.

@treo treo requested a review from devenyantis October 9, 2021 17:57
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 51 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devenyantis devenyantis merged commit c4e692f into remove_static_object Oct 13, 2021
@devenyantis devenyantis deleted the treo/native_ui_refactoring branch October 13, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants