CERT-7012 Add New Listing Check #9
Conversation
github-actions
bot
force-pushed
the
niv/CERT-7012-NewListing
branch
from
965c26e to
822dbb1
Compare
github-actions
bot
force-pushed
the
niv/CERT-7012-NewListing
branch
from
822dbb1 to
217a490
Compare
| @@ -19,7 +19,7 @@ def __init__(self, customer: str, chain: Chain, proposal_address: str, source_co | |||
| self.check_folder.mkdir(parents=True, exist_ok=True) | |||
|
|
|||
|
|
|||
| def _write_to_file(self, path: str | Path, data: dict | str) -> None: | |||
| def _write_to_file(self, path: str | Path, data: dict | str | list) -> None: | |||
There was a problem hiding this comment.
In this case I think Any should be more suitable
There was a problem hiding this comment.
Prefer to be specific for now if there are more types in the future i will change that.
ProposalTools/Utils/source_code.py
Outdated
| """ | ||
| Retrieves the functions from the Solidity contract. | ||
|
|
||
| Returns: | ||
| (list | None): List of functions or None if not found. | ||
| (dict | None): List of functions or None if not found. |
There was a problem hiding this comment.
Was this always returning a dict?
If so please change the txt as well.
| for statement in function_node.get('body', {}).get('statements', []): | ||
| if statement.get('type') == 'VariableDeclarationStatement': | ||
| for var in statement.get('variables', []): | ||
| if var.get('typeName', {}).get('baseTypeName', {}).get('namePath') == 'IAaveV3ConfigEngine.Listing': |
There was a problem hiding this comment.
Why this is specific "IAaveV3ConfigEngine"?
There was a problem hiding this comment.
This is the structure of the TAC when trying to fetch the listing variables.
| for statement in function_node.get('body', {}).get('statements', []): | ||
| if statement.get('type') == 'ExpressionStatement': | ||
| expression = statement.get('expression', {}) | ||
| if expression.get('type') == 'FunctionCall': | ||
| function_name = expression.get('expression', {}).get('name', "") |
There was a problem hiding this comment.
This pattern or a similar one seems to be repetitive in 3 (or more) functions, can we maybe combine this to 1 flow?
I haven't had the chance to dig deep into details, but it seems like collecting the data can be done in 1 loop? or am I'm wrong here?
There was a problem hiding this comment.
I can write every thing in one huge function, but it will frustrating to keep up with what happens there and the lack of documentations.
https://certora.atlassian.net/browse/CERT-7012