Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade should remove the leading slash in tile url #7

Open
lilleyse opened this issue Mar 30, 2018 · 3 comments
Open

Upgrade should remove the leading slash in tile url #7

lilleyse opened this issue Mar 30, 2018 · 3 comments

Comments

@lilleyse
Copy link
Contributor

If a tile url has a leading slash it should be treated as a warning, if not an error.

See CesiumGS/cesium#6125

@lilleyse
Copy link
Contributor Author

Also add this fix to the upgrade command in 3d-tiles-tools to help fix existing tilesets.

@javagl
Copy link
Contributor

javagl commented Oct 3, 2022

I'll consider this as a special case of CesiumGS/3d-tiles-validator#208 for the validator part.

So I'll transfer this one to the tools repository, to handle the possible change in the upgrade function.

@javagl javagl transferred this issue from CesiumGS/3d-tiles-validator Oct 3, 2022
@javagl javagl changed the title Validator- check for leading slash in tile url Upgrade should remove the leading slash in tile url Oct 3, 2022
@javagl
Copy link
Contributor

javagl commented Apr 17, 2023

Right now, the upgrade does not remove the leading slash. But this function could be added trivially.

If there really are tilesets that use a leading slash, one could make a stronger case for removing it: For things like 3TZ, paths are expected to have no leading slash. This is currently ensured (again) in the 3TZ writing layer.

The only concern that I'd have: The specification does not say anything about that. I think that a leading slash should be valid, and would have a hard time justifying why the URI should be modified if it is not necessary...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants